-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
500 Fix deepedit orientation issue [skip mgpu] #501
Merged
yiheng-wang-nv
merged 9 commits into
Project-MONAI:dev
from
yiheng-wang-nv:500-update-deepedit-bundle
Sep 8, 2023
Merged
500 Fix deepedit orientation issue [skip mgpu] #501
yiheng-wang-nv
merged 9 commits into
Project-MONAI:dev
from
yiheng-wang-nv:500-update-deepedit-bundle
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv
commented
Sep 7, 2023
Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv
commented
Sep 7, 2023
/build |
diazandr3s
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Signed-off-by: Yiheng Wang <[email protected]>
/build |
Signed-off-by: Yiheng Wang <[email protected]>
/build |
Nic-Ma
approved these changes
Sep 7, 2023
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
/build |
yiheng-wang-nv
changed the title
500 Fix deepedit orientation issue
500 Fix deepedit orientation issue [skip mgpu]
Sep 8, 2023
/build |
Signed-off-by: Yiheng Wang <[email protected]>
/build |
for more information, see https://pre-commit.ci
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
Fixes Project-MONAI#500 . ### Description This PR is used to fix the orientation issue of the spleen deepedit annotation bundle. This PR refers to Project-MONAI/MONAILabel#1537 ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500 .
Description
This PR is used to fix the orientation issue of the spleen deepedit annotation bundle.
This PR refers to Project-MONAI/MONAILabel#1537
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat
.version
andchangelog
inmetadata.json
if changing an existing bundle.CONTRIBUTING.md
).monai
,pytorch
andnumpy
are correct inmetadata.json
.eval_metrics
of the provided weights and TorchScript modules.large_file.yml
./home/your_name/
for"bundle_root"
).