Update Dockerfile

[kartikshastrakar]

correct relate update

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[ericspod]

Hi @kartikshastrakar thanks for the contribution but could you explain the rationale behind these changes? I don't think any of them should be accepted as they are, so if there's something you needed to accomplish here we can review and see what to do.

[kartikshastrakar]

Hi , Actuall i was trying to change the dockerfile in it and had updated it

…

On Fri, 4 Oct 2024 at 7:13 PM, Eric Kerfoot ***@***.***> wrote: Hi @kartikshastrakar <https://github.com/kartikshastrakar> thanks for the contribution but could you explain the rationale behind these changes? I don't think any of them should be accepted as they are, so if there's something you needed to accomplish here we can review and see what to do. — Reply to this email directly, view it on GitHub <#8124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATOZRTKXNFFQ45AXVBNJKMLZZ2LQLAVCNFSM6AAAAABPEAKACWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTG42DAMRZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kartikshastrakar]

also only one check is skipped else all are fine i have attached a snap because while using the monai ai i face some difficulties so i have changed On Fri, 4 Oct 2024 at 7:31 PM, Kartik Shastrakar < ***@***.***> wrote:

…

Hi , Actuall i was trying to change the dockerfile in it and had updated it On Fri, 4 Oct 2024 at 7:13 PM, Eric Kerfoot ***@***.***> wrote: > Hi @kartikshastrakar <https://github.com/kartikshastrakar> thanks for > the contribution but could you explain the rationale behind these changes? > I don't think any of them should be accepted as they are, so if there's > something you needed to accomplish here we can review and see what to do. > > — > Reply to this email directly, view it on GitHub > <#8124 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATOZRTKXNFFQ45AXVBNJKMLZZ2LQLAVCNFSM6AAAAABPEAKACWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTG42DAMRZGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[ericspod]

also only one check is skipped else all are fine i have attached a snap because while using the monai ai i face some difficulties so i have changed

The other checks will be fine because the code base wasn't changed, only the Dockerfile. Was there something specific with the issues you were having? As I said I don't think these changes should be accepted as they are, we need to see what wasn't working for you and then if we can modify the Dockerfile without breaking it for others. For example, we shouldn't remove the license header, nor remove the aarch64 install in the first RUN section. If you wanted a modified Dockerfile for your own purposes only, I would suggest to keep it in your own fork and not to propose the PR here.

[kartikshastrakar]

Ok, thanks for the clarification.

…

On Fri, 4 Oct 2024 at 7:43 PM, Eric Kerfoot ***@***.***> wrote: also only one check is skipped else all are fine i have attached a snap because while using the monai ai i face some difficulties so i have changed The other checks will be fine because the code base wasn't changed, only the Dockerfile. Was there something specific with the issues you were having? As I said I don't think these changes should be accepted as they are, we need to see what wasn't working for you and then if we can modify the Dockerfile without breaking it for others. For example, we shouldn't remove the license header, nor remove the aarch64 install in the first RUN section. If you wanted a modified Dockerfile for your own purposes only, I would suggest to keep it in your own fork and not to propose the PR here. — Reply to this email directly, view it on GitHub <#8124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATOZRTLDNZDHWN5RGAHI2WDZZ2O7RAVCNFSM6AAAAABPEAKACWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTHAYTAOBTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kartikshastrakar]

thank you for clarification