Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround 5882 reenable weekly preview release #5887

Merged
merged 5 commits into from
Jan 23, 2023
Merged

workaround 5882 reenable weekly preview release #5887

merged 5 commits into from
Jan 23, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 23, 2023

part of #5882

Description

a workaround to not installing MetricsReloaded when packaging.
once pip install MetricsReloaded is made available we can undo the workaround.

workflow tested https://github.com/Project-MONAI/MONAI/actions/runs/3984778767/jobs/6831377542

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 4 commits January 23, 2023 08:45
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from ericspod and rijobro January 23, 2023 09:14
@wyli wyli marked this pull request as ready for review January 23, 2023 09:14
@wyli wyli requested a review from Warvito January 23, 2023 09:17
@wyli
Copy link
Contributor Author

wyli commented Jan 23, 2023

/build

@wyli wyli enabled auto-merge (squash) January 23, 2023 10:13
@wyli wyli merged commit 86a06f3 into dev Jan 23, 2023
@wyli wyli deleted the workaround-5882 branch January 23, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants