Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : 회원 가입 API 개선 #60

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

ParkJuhan94
Copy link
Contributor

📑 작업 상세 내용

  • 회원 가입시에 사용자가 선호 카테고리를 선택한 데이터가 PreferredProductCategory 테이블에 저장되도록 했습니다.
  • ProductCategory 의 기존 필드 categoryValue 가 어색하여 value 로 변경했습니다. (리뷰라벨 테이블의 value 처럼)
  • ProductCategoryLike 클래스 이름도 PreferredProductCategory 로 변경했습니다.

💫 작업 요약

  • 회원 가입 API 개선

🔍 중점적으로 리뷰 할 부분

  • UserService

@ParkJuhan94 ParkJuhan94 requested a review from hyun2371 March 4, 2024 12:33
@ParkJuhan94 ParkJuhan94 self-assigned this Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

Test Results

85 tests  ±0   85 ✅ ±0   22s ⏱️ -1s
23 suites ±0    0 💤 ±0 
23 files   ±0    0 ❌ ±0 

Results for commit e46bc3e. ± Comparison against base commit 5d992da.

♻️ This comment has been updated with latest results.

Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다~ 궁금한 점 하나 남겼어요

@@ -73,6 +90,7 @@ void getUserByIdFailTest() {
}

@Test
@MockitoSettings(strictness = Strictness.LENIENT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 어노테이션은 무슨 역할을 하나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mokito 의 엄격한 수준을 한 단계 낮추는 것입니다!

@hyun2371 hyun2371 added the refactor 리팩토링 label Mar 4, 2024
@ParkJuhan94 ParkJuhan94 merged commit f3c2f81 into dev Mar 5, 2024
3 checks passed
@ParkJuhan94 ParkJuhan94 deleted the feat/#54/user-join-api-improve branch March 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request refactor 리팩토링 빠른 리뷰가 필요해요!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants