Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] : 입찰 등록, 단건 조회, 3개 조회 API #32
[feat] : 입찰 등록, 단건 조회, 3개 조회 API #32
Changes from all commits
8dbb3a2
95ba699
215dafe
274f63c
fa3b974
3853daf
6cb0647
290e7b9
1f3d498
0fd4771
2032f5d
b4d12ba
1ecbdc1
b5b6470
af3fdf3
5741188
1c0d178
5c2d9d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
biddingPrice만 validation이랑 같이 request로 빼고 auctionId, user는 service에 그대로 넘겨줘도 괜찮을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service.registerBidding(request)
만 작성하고 나머지는 서비스단으로 넘겨야 할 것 같습니다.