Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick all new changes #353
Pick all new changes #353
Changes from 1 commit
8d3d5ca
2a0533c
aeeb012
edf1def
bb26208
7b08d17
bc474cc
42a11dd
714bf3d
e519e69
2e3f30a
50b5c76
37a3a7b
860ed43
8a563ae
0285401
8e385c6
3c8200a
d58867b
b405289
b1b03f0
7eb2d54
2ea2f53
6deb405
359930d
6f6f089
1d895a3
e5f1810
ff52875
947f76a
c36f52c
dcb6011
8363c12
cce07c9
cc8675f
96d42d6
9f00b52
ba04bc8
49ff10a
0c1b404
3bce2bc
02f9eaa
ccc729b
7f4f69c
a8c2af0
b12783f
82f611f
6bdecc0
699688d
fd5462f
f4ccf5b
ed3dadd
ab2d721
3797122
8504fa5
8fcfcf1
2a9ae33
ae8a2af
c7a38a7
3551bed
3c6af46
b9c7f1f
6fcdaed
a4a6de6
039295b
6adf25e
1f8c593
6aefd64
ae45bc5
31ca9db
5f8d8b6
077c20a
be01da9
6d1a891
8a948d1
9b71088
670c560
9976b9a
190c511
9787f79
f92c1f7
b9f621d
fc9fc8b
47f86ca
f897a6e
0c1607b
e51e7c2
6faa3c6
734ecdf
54d6598
7005634
7622a15
e66862d
342a2f0
ce566b0
bebd65e
70681fa
c4ae650
4cf323c
e04fef0
c9b2b1c
aeca97d
2d8d522
f856bc5
0dca522
bfd8279
dfa45a5
78d4b62
bc51c9f
29b47fb
6f2c030
5044e4e
033eeef
767ca3f
f589032
c41c010
83627a5
ffaa523
33ddfa1
e2670a5
6e8e3ca
b8b8f7b
3decbe3
2895a1f
898648d
3008be0
bd98795
0929e60
16c42de
c3a189d
659b089
7bd9a5c
f2677ee
e99faef
d414996
ddd763c
2bceab9
af288d3
e18722c
5e6cd63
8adee6a
e6354f6
8a093b2
9947c13
1f14154
6074e18
f475364
7edddf8
38e0c08
4b01819
348aa26
111c97c
06ea7dd
c6b78c3
214ec56
b7c6a8f
f33db2c
3a71f43
e95b776
2c64bca
9b0828b
4f33758
155d994
2a85497
d8feab7
d5f4853
a6da82e
9cd3b95
3b97408
e1020d5
df41129
95a5598
f2fff9f
60ea5b9
ecab69f
b720d45
d9988c3
badf004
3176893
962b689
57cb655
44515c9
1afdf5b
47ccc70
1d94117
17a6048
202bd02
81e6e56
af6d749
a7fb8c6
9a83884
65840cf
ec2e917
f1917a5
6dd9a95
4cff9f5
52d2ea7
d210aca
2905567
43342a7
fb27c56
369a4ae
145ae51
39c7fb3
f8ed865
eed9736
cc48883
38d1a58
09a9550
62f3f72
dad3b6d
2896971
611f07b
37d1ca0
c5cffc1
0f11227
47b895d
e4265e2
34dcd5c
ae18411
e7c2b98
fd8445d
c728d79
2f35f00
25d858e
9dc6a43
ffa2c08
b360187
f5c07e0
b38ec08
38e2621
f8ae3e1
a99a8ff
18e5022
fa564bf
7a77b2d
9dde8f0
9d9e774
7f67f8b
3be311d
4910354
6f56bab
f081d16
bcb10e3
443d89b
5bdf626
f60e363
295253c
0633d8d
9bb29a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why react ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the type of guy who just decided to make a full rewrite using my favorite frameworks. I removed lit in the latest version not only because React has a much greater ecosystem (such as good storybook support) & clean function components and I didn't see a single reason to use lit. I could adopt, really, but there was a thing that was blocking a lot of stuff. The main reason why I had to drop lit is the shadow dom (e.g. no way of using global CSS variables).
I've enjoyed the rewrite and am happy with the final result, but if you're not I'm sorry! I actually didn't see other solutions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is one of the best feature of lit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How?
This is the same as saying that "no way to build scalable applications is also the best feature of lit". These kinds of restrictions don't make code more maintainable it just makes it harder to find solutions. Meanwhile react has the best ecosystem you can find if you're a frontend developer, it still is the fastest & easiest way to build robust UI at scale. Just take the current storybook integration: zero-config first-class react support. I tried to adopt lit, but it sucks at absolutely everything, no good state management, no hmr, plugins and so on... Also, my team could easily work with react + ts and even build new components without any problems so I don't see objective points here, for most other devs it doesn't really make the difference what framework you use...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global css makes it impossible to build reusable components, it's not much more complicated than that
that's why react doesn't really have reusable components but instead it has sets of components you need to all use together
beyond that, regarding what framework to use here, I am not yet convinced we need anything big as react / state management / etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the only way forward here is for me to go and pick stuff that makes sense from your fork, and eventually we converge to something reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But React is not that big and at some points even easier to learn. You just need to understand how Function components work and that's. And what is more reasonable from your point? This is an absolutely fantastic & simple UI framework (any frontend guy would say you the same), I don't understand what's the issue with that (sorry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm the frontend guy and React is pretty bad, actually. There's much simpler ones like Svelte, and more performant ones like Solid. This project probably uses Lit for a good reason, like reducing bundle size, and we need to respect that (unless majority agrees to migrate to something else).