Update ci.yml actions/upload-artifact #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
What about line 60 ? |
|
It's not run under the matrix |
|
Exactly that's the problem. Before all the files of the matrix ended up in
a single artifact as a zip with one file per version inside.
The download was retrieving that single zip and getting all the files at
once.
Now that the upload action wants to do one artifact per version, we need
download to loop through all the versions and download all the artifacts
…On Wed, Jan 8, 2025, 10:19 extremeheat ***@***.***> wrote:
It's not run under the matrix
—
Reply to this email directly, view it on GitHub
<#448 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437W6T4K47RP4FNRSJR32JTURZAVCNFSM6AAAAABUYZ32GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXGE3TMNBQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Ah, I think I fixed it with the action's pattern feature mention here - https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing CI
https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact
Fix #440