World rendering improvements #408
Conversation
|
hi, sorry for delay CI is failing, could you make it work? |
|
I fixed the ci |
| function loadTexture (texture, cb) { | ||
| if (process.platform === 'browser') { | ||
| return require('./utils.web').loadTexture(texture, cb) |
There was a problem hiding this comment.
why is this needed? didn't it work before?
| @@ -22,6 +27,9 @@ function loadTexture (texture, cb) { | |||
| } | |||
|
|
|||
| function loadJSON (json, cb) { | |||
| if (process.platform === 'browser') { | |||
| return require('./utils.web').loadJSON(json, cb) | |||
There was a problem hiding this comment.
why is this needed? didn't it work before?
There was a problem hiding this comment.
As said in the body I moved to esbuild in my p viewer setup so I guess that's why I added it. If this is the only thing that blocks merging the pr and you don't want to see it you can remove it (feel free to do it since you should have push access)
| texture.magFilter = THREE.NearestFilter | ||
| texture.minFilter = THREE.NearestFilter | ||
| texture.flipY = false | ||
| this.material.map = texture | ||
| }) | ||
|
|
||
| loadJSON(`blocksStates/${version}.json`, blockStates => { | ||
| const loadBlockStates = () => { |
There was a problem hiding this comment.
why is this needed? didn't it work before?
There was a problem hiding this comment.
Still works, but now you can override logic of getting block states via exposed property so you can skip network request. Ideally it should also set to this property if wasn't set before after request, fixed in my version but not here but that's not a big issue imo. Overall it's not a bug fix, it's a customisation improvement
|
Most things LGTM I left 2 comments |
|
/makerelease |
|
Thanks! |
Basically I picked almost all changes from my fork here. I've also dramatically changed the build pipeline (migrated everything to esbuild), but I didn't pick these changes here. So it won't be in sync.
I've separated changes by commits so I do hope it is still not hard to review :)
Added missing texture from invsprite from prismarine web client. Though it would be cool to think of a way to bring old behavior for some blocks if user really wants it for some reason.
Resourcepack support is done by supplying a custom atlas image generated with script like this. Of course would be better to think of exposing such functionality here, but it is not my priority for now. Also added a way to supply custom block state json so you can have any texture size (e.g. 1024x)
Also in prismarine web client I'm currently going to load textures and block states before joining the server or implement a loader indicator so user have understanding that textures are being loaded.