Fix version check. (#413)

* Fix version check.

* Update supported versions.

* Check file size of screenshot.

* Fix.

.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
 
     strategy:
       matrix:
-        mcVersion: ['1.8.8', '1.9.4', '1.10.2', '1.11.2', '1.12.2', '1.13.2', '1.14.4', '1.15.2', '1.16.1', '1.16.4', '1.17.1', '1.18.1', '1.19.1', '1.20.1']
+        mcVersion: ['1.8.8', '1.9.4', '1.10.2', '1.11.2', '1.12.2', '1.13.2', '1.14.4', '1.15.2', '1.16.1', '1.16.4', '1.17.1', '1.18.1', '1.19', '1.20.1']
       fail-fast: false
 
     steps:

.gitignore

@@ -11,3 +11,4 @@ examples/standalone/public/worker.js
 examples/standalone/public/textures/
 examples/standalone/public/blocksStates/
 *.DS_Store
+test/server_*

README.md

@@ -13,7 +13,7 @@ Web based viewer for servers and bots
 
 [<img src="https://prismarinejs.github.io/prismarine-viewer/test_1.18.1.png" alt="viewer" width="300">](https://prismarinejs.github.io/prismarine-viewer/)
 
-Supports versions 1.8.8, 1.9.4, 1.10.2, 1.11.2, 1.12.2, 1.13.2, 1.14.4, 1.15.2, 1.16.1, 1.16.4, 1.17.1, 1.18.1, 1.19.1, 1.20.1.
+Supports versions 1.8.8, 1.9.4, 1.10.2, 1.11.2, 1.12.2, 1.13.2, 1.14.4, 1.15.2, 1.16.1, 1.16.4, 1.17.1, 1.18.1, 1.19, 1.20.1.
 
 ## Install
 

examples/exporter/3dmodel.js

@@ -31,7 +31,7 @@ const main = async () => {
 
   await schem.paste(world, new Vec3(0, 60, 0))
 
-  if (viewer.setVersion(version)) {
+  if (!viewer.setVersion(version)) {
     return false
   }
 

examples/exporter/screenshot.js

@@ -32,7 +32,7 @@ const main = async () => {
 
   await schem.paste(world, new Vec3(0, 60, 0))
 
-  if (viewer.setVersion(version)) {
+  if (!viewer.setVersion(version)) {
     return false
   }
 

examples/standalone/index.js

@@ -29,7 +29,7 @@ async function main () {
 
   // Create viewer
   const viewer = new Viewer(renderer)
-  if (viewer.setVersion(version)) {
+  if (!viewer.setVersion(version)) {
     return false
   }
   // Attach controls to viewer

examples/web_client/index.js

@@ -44,7 +44,7 @@ async function main () {
 
     // Create viewer
     const viewer = new Viewer(renderer)
-    if (viewer.setVersion(version)) {
+    if (!viewer.setVersion(version)) {
       return false
     }
 

lib/headless.js

@@ -19,7 +19,7 @@ module.exports = (bot, { viewDistance = 6, output = 'output.mp4', frames = -1, w
   const renderer = new THREE.WebGLRenderer({ canvas })
   const viewer = new Viewer(renderer)
 
-  if (viewer.setVersion(bot.version)) {
+  if (!viewer.setVersion(bot.version)) {
     return false
   }
   viewer.setFirstPersonCamera(bot.entity.position, bot.entity.yaw, bot.entity.pitch)

lib/index.js

@@ -35,7 +35,7 @@ window.addEventListener('resize', () => {
 })
 
 socket.on('version', (version) => {
-  if (viewer.setVersion(version)) {
+  if (!viewer.setVersion(version)) {
     return false
   }
 

test/viewer.test.js

@@ -2,6 +2,7 @@
 /* global page */
 
 const supportedVersions = require('../').supportedVersions
+const fs = require('fs')
 
 const path = require('path')
 const MC_SERVER_PATH = path.join(__dirname, 'server')
@@ -117,7 +118,15 @@ supportedVersions.forEach(function (supportedVersion) {
               exit(pageerr)
             })
             setTimeout(() => {
-              page.screenshot({ path: path.join(__dirname, `test_${supportedVersion}.png`) }).then(() => exit()).catch(err => exit(err))
+              const fileName = path.join(__dirname, `test_${supportedVersion}.png`)
+              page.screenshot({ path: fileName }).then(() => {
+                const fileSize = fs.statSync(fileName).size
+                if (fileSize < 100000) {
+                  exit(new Error(`The file size of ${fileName} is ${fileSize}. This is less than 100KB, and is likely an empty render.`))
+                } else {
+                  exit()
+                }
+              }).catch(err => exit(err))
             }, TIMEOUT_SCREENSHOT)
           }).catch(err => exit(err))
         })

viewer/lib/version.js

@@ -1,4 +1,4 @@
-const supportedVersions = ['1.8.8', '1.9.4', '1.10.2', '1.11.2', '1.12.2', '1.13.2', '1.14.4', '1.15.2', '1.16.1', '1.16.4', '1.17.1', '1.18.1', '1.19.1', '1.20.2']
+const supportedVersions = ['1.8.8', '1.9.4', '1.10.2', '1.11.2', '1.12.2', '1.13.2', '1.14.4', '1.15.2', '1.16.1', '1.16.4', '1.17.1', '1.18.1', '1.19', '1.20.1']
 
 const lastOfMajor = {}
 for (const version of supportedVersions) {