Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): do not make properties of the block optional #358

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Aug 31, 2024

i have no idea what was the point of making all the properties of the block optional, fixed

@zardoy zardoy changed the title regression: do not make properties of the block optional fix(types): do not make properties of the block optional Aug 31, 2024
@bdkopen
Copy link
Contributor

bdkopen commented Sep 8, 2024

This fixed the type regression from #348 for me. Would be great to get this released!

@zardoy
Copy link
Contributor Author

zardoy commented Sep 8, 2024

This fixed the type regression from #348 for me.

Yes that's what I meant. Very stupid I didn't review the code which was obviously incorrect. However, since no one complained before I believe only we two have strict mode enabled in our projects. And yeah, I'm also eagerly waiting for this to be released asap!

@extremeheat extremeheat merged commit b380715 into PrismarineJS:master Sep 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants