Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GETP-106 feature: Button, Input, Label 컴포넌트 구현 #6

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

toothlessdev
Copy link
Member

✨ 구현한 기능

  • Button 컴포넌트 구현 및 스토리북 작성
  • Input 컴포넌트 구현 및 스토리북 작성
  • Label 컴포넌트 구현 및 스토리북 작성

📢 논의하고 싶은 내용

  • Input 컴포넌트의 재사용성을 높이기위해 children props 로 우측에 옵션으로 들어갈 컴포넌트를 받는것이 확장성에 용이한가
  • React.ComponentProps 와 rest props 에 대해 같이 정리해보면 좋을 것 같습니다
  • 참고글 : HTMLAttributes, HTMLProp 을 쓰지 마세요!

🎸 기타

  • StoryBook 에서 children props 를 테스팅할때, Story 의 render 프로퍼티로 콜백함수를 넘기면됍니다! (저도 방금배움)
  • 단, 스토리북의 확장자가 .story.tsx 이어야 합니다!
export const Email: Story = {
    args: {
        type: "email",
        width: "300px",
        height: "45px",
    },
    render: (args) => {
        return (
            <Input width={args.width} height={args.height} placeholder="이메일 주소를 입력해주세요">
                <Button variant="side" width="40px" height="45px">
                    인증
                </Button>
            </Input>
        );
    },
};

@toothlessdev toothlessdev changed the title GETP-106 feature: GETP-106 feature: Button, Input, Label 컴포넌트 구현 Mar 23, 2024
Copy link
Contributor

@zladb zladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway LGTM 🫡

src/common/form/Input.style.tsx Show resolved Hide resolved
Copy link
Contributor

@zladb zladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LGTM

@toothlessdev toothlessdev merged commit d5eb974 into develop Mar 29, 2024
2 checks passed
@toothlessdev toothlessdev deleted the feature/GETP-106 branch April 9, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants