Refactor: 공통 응답 분기 Advice #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Related Issue
close: #6
📌 Tasks
ApiResponse에서 다발적으로 사용된success,error함수를 사용하지 않고도 응답 형식을 분기할 수 있도록 개선합니다.ApiResponse<Object>형태의 봉투 패턴 대신ResponseBodyAdvice구현체로 분리하여 별도의 DTO를 만들어도 동일한 형식으로 매핑됩니다.📝 Details
pageInfo필드를 공통 형식에서 제거하고, 필요한 경우에만PageInfoResponse를 DTO에서 쓰도록 수정했는데, 이 부분이 이후 사용에서도 좋은 구조일지 의견을 구합니다.📚 Remarks