Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand documentation for Friends 3DS #36

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ZeroSkill1
Copy link
Contributor

@ZeroSkill1 ZeroSkill1 commented Jan 10, 2025

Resolves #XXX

Changes:

Add values for the m_ChangedBitFlag enum in NintendoPresence, the remaining "Unknown" fields in MyProfile and AccountExtraInfo based on reverse engineering of the 3DS friends module.

Copy link
Member

@DaniElectra DaniElectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Do you also happen to know anything about the AccountExtraInfo or the NintendoCreateAccountData structures?

docs/nex/protocols/friends-3ds.md Show resolved Hide resolved
docs/nex/protocols/friends-3ds.md Outdated Show resolved Hide resolved
@ZeroSkill1
Copy link
Contributor Author

ZeroSkill1 commented Jan 11, 2025

NintendoCreateAccountData is completely absent in the friends module. However, AccountExtraInfo is present though I'm not certain of one specific field. It appears to be some kind of counter, and looking through existing documentation, I was only able to find something called MoveCount in some error descriptions? The value used for creating this structure can be incremented using frd:a IPC command 0x410. This value isn't used anywhere else IIRC.

@jonbarrow
Copy link
Member

I was only able to find something called MoveCount in some error descriptions?

I wonder if this is related to system transfers? Tracking how many times an account has "moved" consoles?

@ZeroSkill1
Copy link
Contributor Author

There is no way to retrieve this supposed MoveCount using any IPC command. I've also searched all official system titles and not a single one even uses the command that increments it (that includes all the ones involved in the system transfer process).

@DaniElectra
Copy link
Member

However, AccountExtraInfo is present though I'm not certain of one specific field

Even if you don't have fully documented the structure, can you include any new field names?

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@ZeroSkill1 ZeroSkill1 changed the title feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS) feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS), populate unknown fields of AccountExtraInfo Feb 5, 2025
@ZeroSkill1
Copy link
Contributor Author

ZeroSkill1 commented Feb 5, 2025

I've added the remaining field names for AccountExtraInfo and have decided to stick with MoveCount for the other unknown value as it is the only possible name I can think of, especially given the existence of this name in a Wii U NEX error code list.

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@DaniElectra DaniElectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some style changes for consistency

docs/nex/protocols/account-management.md Outdated Show resolved Hide resolved
docs/nex/protocols/friends-3ds.md Outdated Show resolved Hide resolved
@DaniElectra DaniElectra changed the title feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS), populate unknown fields of AccountExtraInfo feat: Expand documentation for Friends 3DS Feb 6, 2025
@DaniElectra DaniElectra merged commit 028710a into PretendoNetwork:master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants