Merge pull request #20 from Progi1984/178xInstall

1.7.8 : Changed the behavior for install modules
PrestaShop · Mar 20, 2024 · f8a3159 · f8a3159
2 parents 323b5a5 + 385be68
commit f8a3159
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/interfaces/BO/modules/moduleManager/uninstalledModules.ts b/src/interfaces/BO/modules/moduleManager/uninstalledModules.ts
@@ -5,5 +5,5 @@ export interface ModuleManagerUninstalledModulesPageInterface extends BOBasePage
     readonly installMessageSuccessful: (moduleTag: string) => string;
 
     goToTabUninstalledModules(page: Page): Promise<void>;
-    installModule(page: Page, moduleTag: string): Promise<string|null>;
+    installModule(page: Page, moduleTag: string): Promise<boolean>;
 }
diff --git a/src/versions/1.7.8/pages/BO/modules/moduleManager/uninstalledModules.ts b/src/versions/1.7.8/pages/BO/modules/moduleManager/uninstalledModules.ts
@@ -42,15 +42,15 @@ class UninstalledModules extends BOBasePage implements ModuleManagerUninstalledM
   }
 
   /**
-   * Install the module and return the growl message
+   * Install the module and return if installed
    * @param {Page} page
    * @param {string} moduleTag
-   * @returns {Promise<string|null>}
+   * @returns {Promise<boolean>}
    */
-  async installModule(page: Page, moduleTag: string): Promise<string|null> {
+  async installModule(page: Page, moduleTag: string): Promise<boolean> {
     await page.locator(this.installModuleButton(moduleTag)).click();
 
-    return this.getGrowlMessageContent(page);
+    return !(await this.elementNotVisible(page, this.installModuleButton(moduleTag)));
   }
 }
 

diff --git a/src/versions/mock/pages/BO/modules/moduleManager/uninstalledModules.ts b/src/versions/mock/pages/BO/modules/moduleManager/uninstalledModules.ts
@@ -31,11 +31,11 @@ class UninstalledModules extends BOBasePage implements ModuleManagerUninstalledM
   }
 
   /**
-   * Install the module and return the growl message
-   * @returns {Promise<string|null>}
+   * Install the module and return if installed
+   * @returns {Promise<boolean>}
    */
-  async installModule(): Promise<string|null> {
-    return '';
+  async installModule(): Promise<boolean> {
+    return true;
   }
 }