-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next-item pipeline #561
Conversation
I added
|
General comment. I see some formatting changes. Let's stick to "black" formatting to remain consistent across the library. |
@hieuddo @lthoang this PR is getting very complicated to review. Let's not keep adding more features (e.g., iterators) to this until we need them for other models in the future PRs. If this is sufficient to run the SPop baseline and do evaluation, I would suggest to revise the current code carefully and merge this PR. |
@tqtg I keep some iterators that i think should be standard enough for accessing data in sequence level and user level. The non-standard iterator (i.e., input-output iterators) has been removed from the current PR. |
LGTM |
Description
data.dataset.SequentialDataset
to support new data formats:data.reader
parser for listed formatseval_method.NextItemEvaluation
for next-item evaluationmodels.SPop
baseline model: session-based popularRelated Issues
#543
Todo
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).