-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCMC Invalid Key Error #533
Fix GCMC Invalid Key Error #533
Conversation
@darrylong to make it right, I think we need to do something similar to the predict function. Basically, we need to create a test decoding graph for that particular user (connecting from the user node to all item nodes), then call the model and obtain predicted ratings for all items. Let me know what you think. |
I think that should work. I'll give it a try! |
@tqtg while I was attempting to add individual dec_graphs of each user, I thought about the possibility of adding all items for users in the test set into the dec_graph. This could potentially help with the retrieval of scores, but would like to check if this is theoretically correct. |
Do you mean we compute scores for all users in the test set at once? |
That's right. In a single dec_graph just like in the predict function. |
* Add missing default scores when item_idx is none * Added all items into test_dec_graph for all users * changed to create dec_graph for each user when scoring
Description
For instances when predicting scores and item_idx is none:
Solved by returning a default score instead.
Related Issues
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).datasets/README.md
(if you are adding a new dataset).