NCF fix, normalize running loss (#537)

Correct printed running loss --------- Co-authored-by: Quoc-Tuan Truong <[email protected]>
PreferredAI · Oct 24, 2023 · 9b06a51 · 9b06a51
1 parent d300be2
commit 9b06a51
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cornac/models/ncf/recom_ncf_base.py b/cornac/models/ncf/recom_ncf_base.py
@@ -178,8 +178,8 @@ def _fit_tf(self):
                         batch_users, batch_items, batch_ratings
                     ),
                 )
-                count += len(batch_ratings)
-                sum_loss += _loss * len(batch_ratings)
+                count += len(batch_users)
+                sum_loss += len(batch_users) * _loss
                 if i % 10 == 0:
                     loop.set_postfix(loss=(sum_loss / count))
 
@@ -242,7 +242,7 @@ def _fit_pt(self):
                 optimizer.step()
 
                 count += len(batch_users)
-                sum_loss += loss.data.item()
+                sum_loss += len(batch_users) * loss.data.item()
 
                 if batch_id % 10 == 0:
                     loop.set_postfix(loss=(sum_loss / count))