Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cached variables at the start of the build #912

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bnmnetp
Copy link
Contributor

@bnmnetp bnmnetp commented Feb 4, 2025

So, the reload trick did not work. But this solution does.

I just built welcomecs2 and dmoi-4 back to back and they both have the right theme!

Tagging: @ascholerChemeketa

This still feels like a hack until we get the right solution. But reasonable people might disagree on that.

@bnmnetp
Copy link
Contributor Author

bnmnetp commented Feb 4, 2025

Also @oscarlevin - the new cache stuff looks like it is fine.

@ascholerChemeketa
Copy link
Contributor

That seems as good a hack as any.

Still think the better long term answer is to pull the caching out of pretext and add some hooks to pass in an already parsed dict of pub vars. If the state causes problems, let's get rid of it.

@oscarlevin
Copy link
Member

Ah, that's gorgeous. Very nice. I'll merge this and release 2.13 later today.

@oscarlevin oscarlevin merged commit d0afbb9 into PreTeXtBook:main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants