Enforce pep8-naming conventions in tooling #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Comment on lines
+16
to
+20
| # Limit for how many entries to allow in the server file | ||
| # before attempting to clean up non-running entries. | ||
| # Note: This is not a limit to the number of concurrent servers. | ||
| PURGE_LIMIT = 10 | ||
|
|
There was a problem hiding this comment.
This appears to be unrelated to the pep8 stuff, so don't forget to open a new PR to implement this
There was a problem hiding this comment.
It was a constant that was defined inside the one function that uses it, but pep8-naming complained about the all-caps use there, so I moved it to the top. If I leave it back without renaming we would be getting pep8-naming errors.
There was a problem hiding this comment.
nm, I see this was moved out to be a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.