add CLI #24
Merged
add CLI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgovers
force-pushed
the
feature/example-cli
branch
2 times, most recently
from
c2eb31f to
e14ec9b
Compare
Signed-off-by: Martijn Govers <[email protected]>
mgovers
force-pushed
the
feature/example-cli
branch
from
e14ec9b to
8c2a6c3
Compare
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
|
...model_io_native_c/power_grid_model_io_native_c/include/power_grid_model_io_native_c/basics.h
Show resolved
Hide resolved
..._native_c/power_grid_model_io_native/include/power_grid_model_io_native/common/exception.hpp
Show resolved
Hide resolved
..._native_c/power_grid_model_io_native/include/power_grid_model_io_native/common/exception.hpp
Show resolved
Hide resolved
..._native_c/power_grid_model_io_native/include/power_grid_model_io_native/common/exception.hpp
Show resolved
Hide resolved
..._native_c/power_grid_model_io_native/include/power_grid_model_io_native/common/exception.hpp
Show resolved
Hide resolved
..._native_c/power_grid_model_io_native/include/power_grid_model_io_native/common/exception.hpp
Show resolved
Hide resolved
|
Since only nitpicks remain, I will resolve the comments and approve (#24 (comment) and #24 (comment)) |
figueroa1395
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example CLI for the minimal VNF to PGM conversion introduced in #21
Test data in
examples/convert_vnf_to_pgm/data