Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rrweb player version #28244

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Feb 3, 2025

in latest version of playback

css parsing errors kill the player :/

let's not do that

only includes PostHog/posthog-rrweb#49

@pauldambra pauldambra requested a review from veryayskiy February 3, 2025 22:41
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Upgrades three rrweb-related packages to version 0.0.7 to fix CSS parsing errors that were causing the replay player to crash during playback.

  • Updated @posthog/rrweb from 0.0.6 to 0.0.7 in package.json to handle CSS parsing errors gracefully
  • Updated @posthog/rrweb-plugin-console-record to 0.0.7 for compatibility
  • Updated @posthog/rrweb-types to 0.0.7 for type definitions consistency
  • Added error handling in rrweb player to prevent crashes from CSS parsing failures

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Size Change: +5 B (0%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +5 B (0%)

compressed-size-action

Copy link
Contributor

@veryayskiy veryayskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be alive

@pauldambra pauldambra enabled auto-merge (squash) February 4, 2025 08:16
@pauldambra pauldambra merged commit 04d751b into master Feb 4, 2025
99 checks passed
@pauldambra pauldambra deleted the chore/upgrade-rrweb-player-version branch February 4, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants