feat: make delete dag dependent on current most recent squash job results #28243
+68
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the person event deletion process to ensure it only processes events that have been properly squashed by the person overrides job.
- Added
get_oldest_person_override_timestampoperation in/dags/deletes.pyto establish a high watermark for deletions - Modified
squash_person_overridesjob in/dags/person_overrides.pyto pass timestamp through newpass_the_torchoperation - Increased ClickHouse client timeout to 24 hours and added strict mutation sync settings in
ClickhouseClusterResource - Added UUID-based ZooKeeper paths for table replication to prevent conflicts
- Added comprehensive test coverage in
/dags/tests/test_deletes.pyto validate the new timestamp-dependent behavior
3 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+276
to
+278
| query = f""" | ||
| SELECT min(_timestamp) FROM {PERSON_DISTINCT_ID_OVERRIDES_TABLE} | ||
| """ |
There was a problem hiding this comment.
logic: query could return NULL if table is empty, which would cause a runtime error when unpacking result
tkaemming
approved these changes
Feb 3, 2025
oops! Co-authored-by: ted kaemming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The delete job is quite dependent on the current state of the world of person overrides squashing
Changes
This makes the delete job dependent on the min
_timestampseen in person overrides table so that we only delete person events that have been squashed.We do this by having a starting op that grabs the high watermark for person overrides and only deletes events before that.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?