fix(flags): fix broken boolean flag usage tab when null values are present #28242
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context: https://posthoghelp.zendesk.com/agent/tickets/24210
This is a regression caused by https://github.com/PostHog/posthog/pull/27888/files
Changes
This changes both boolean and multivariant flags to render the raw
$feature_flag_response
value in query resultsThere is no value in transforming the $feature_flag_response value in query - it makes SDK behavior far more opaque and makes data seem unreliable as the activity tab will show different results than the Usage tab for a flag
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Edited the failed query in user's project in posthog debugger and made sure results are accurate for both boolean and multivariant flags: