fix(experiments): Apply correct filters to "View recordings" #27849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://posthog.slack.com/archives/C087ZBJBZ7C/p1737128365755459
Also reported in a direct email:
Changes
Introduces a
getViewRecordingFilters()
function with tests to generate the various permutations of filters based on the metric. Note: the screencasts are solely to show the filters being applied; I don't actually have any recordings because I generated the events synthetically.If no filters could be identified, then the button will be disabled:
Funnel with events
CleanShot.2025-01-23.at.15.48.50.mp4
Funnel with action
CleanShot.2025-01-23.at.15.49.42.mp4
Trend with default exposure
CleanShot.2025-01-23.at.15.52.18.mp4
How did you test this code?
Tests should pass + manual review.