Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Email support instead of email an engineer #27838

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jan 23, 2025

Problem

Much confusion around "email an engineer"

Changes

Change it to email support

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR changes the button text from 'Email an engineer' to 'Email support' in the PostHog support interface to improve clarity and consistency in terminology.

  • Inconsistency found: Section title in SupportFormBlock still shows 'Email an engineer' while button text was updated to 'Email support'
  • Should update section title in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelSupport.tsx line 110 to match new terminology

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@timgl timgl enabled auto-merge (squash) January 23, 2025 16:40
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@timgl timgl merged commit 8a6ab27 into master Jan 23, 2025
98 of 99 checks passed
@timgl timgl deleted the email-engineer-email-support branch January 23, 2025 17:36
timgl added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants