Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flappy snapshot #27827

Merged
merged 20 commits into from
Jan 23, 2025
Merged

fix: flappy snapshot #27827

merged 20 commits into from
Jan 23, 2025

Conversation

pauldambra
Copy link
Member

these data flapshots are snapping

i guess it's new conditions or hogql changed

we tend not to replace dates in these snapshot tests i guess because we want to see that filters are working

so i've tried to scope this to just these new flappy snapshots

(i didn't want to figure out if I could freeze time in the tests instead)

@pauldambra pauldambra enabled auto-merge (squash) January 23, 2025 13:14
@pauldambra
Copy link
Member Author

@aspicer I'll get this in to try and save on the "build minutes waited for by engineers" metric 🤣

but it has changed quite a few snapshots... it might be better to freeze time in the original flapping cohort tests than have the snapshots set here

so feel free to revert this if there is a better fix :)

@pauldambra
Copy link
Member Author

assuming it stops updating snapshots before you offer a different fix 🤣

@pauldambra pauldambra merged commit ab260cd into master Jan 23, 2025
92 checks passed
@pauldambra pauldambra deleted the fix/flappy-snapshot branch January 23, 2025 15:47
timgl pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants