-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flappy snapshot #27827
Merged
Merged
fix: flappy snapshot #27827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
approved these changes
Jan 23, 2025
@aspicer I'll get this in to try and save on the "build minutes waited for by engineers" metric 🤣 but it has changed quite a few snapshots... it might be better to freeze time in the original flapping cohort tests than have the snapshots set here so feel free to revert this if there is a better fix :) |
assuming it stops updating snapshots before you offer a different fix 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these data flapshots are snapping
i guess it's new conditions or hogql changed
we tend not to replace dates in these snapshot tests i guess because we want to see that filters are working
so i've tried to scope this to just these new flappy snapshots
(i didn't want to figure out if I could freeze time in the tests instead)