feat(hogql): many children in tags #27826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
had a problem deploying
to
pypi-hogql-parser
GitHub Actions
Error
|
Size Change: +766 B (+0.07%) Total Size: 1.16 MB ℹ️ View Unchanged
|
mariusandra
had a problem deploying
to
pypi-hogql-parser
GitHub Actions
Failure
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
THERE ARE NO UI CHANGES HERE |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
mariusandra
commented
Jan 24, 2025
common/hogql_parser/setup.py
Outdated
| @@ -32,13 +32,13 @@ | |||
|
|
|||
| setup( | |||
| name="hogql_parser", | |||
| version="1.0.50", | |||
| url="https://github.com/PostHog/posthog/tree/master/hogql_parser", | |||
| version="1.0.453", | |||
There was a problem hiding this comment.
Bumping so large because 1.0.452 already existed 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You can do
select <a href={properties.url}>{properties.name}</a>in HogQL, but notselect <a href={properties.url}>{properties.name}{properties.multiple_children}</a>Changes
Fixes it
We still do not support wildcard text inside the nodes (
select <strong>Hello world!</strong>will not work, you have to wrap it in{'Hello'}. This can be fixed, but is a bit more work and will be left for later.Does this work well for both Cloud and self-hosted?
I hope so.
How did you test this code?
Added parsing tests, made sure all other downstream tests (e.g. query runners) kept working.