Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Storybook snapshots for Web Analytics and Web Vitals #27709

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

rafaeelaudibert
Copy link
Member

@rafaeelaudibert rafaeelaudibert commented Jan 20, 2025

Changes

These are way overdue, so here we have some snapshots for UI regressions on Web Analytics and Web Vitals

image

Note

This might look like the Trends charts are not rendering and I have to fix this, but it's actually a known restriction we've self-imposed. See https://posthog.slack.com/archives/C02E3BKC78F/p1737501183808219. I'm working on changing that in a follow-up PR.

In a follow-up PR, I'll attempt to automate copying these snapshots to the posthog.com repo to keep our product screenshots always up to date 🕺🏻

Does this work well for both Cloud and self-hosted?

Not relevant

How did you test this code?

This is literally test code!

@rafaeelaudibert
Copy link
Member Author

Most of the stat numbers in those jsons are our actual numbers. We intend to make them public soon anyway, so I'm not worried about sharing them here. Some of them have been slightly altered because I wanted nicer-looking charts (more randomization on the before/after arrows, for example), ours always look up and to the right, but some random downturns look nicer on the website

@rafaeelaudibert
Copy link
Member Author

rafaeelaudibert commented Jan 20, 2025

@robbie-c This is almost ready, I just need to figure out how can I restrict the width/height from some of these renders to guarantee that they look nicer in the website

@rafaeelaudibert rafaeelaudibert force-pushed the add-storybook-for-web-analytics-and-web-vitals branch from c9f21e5 to 386af42 Compare January 21, 2025 00:17
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Size Change: -766 B (-0.07%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB -766 B (-0.07%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@rafaeelaudibert rafaeelaudibert force-pushed the add-storybook-for-web-analytics-and-web-vitals branch from 0830e50 to f358b83 Compare January 21, 2025 22:29
@rafaeelaudibert rafaeelaudibert enabled auto-merge (squash) January 22, 2025 00:23
@rafaeelaudibert rafaeelaudibert force-pushed the add-storybook-for-web-analytics-and-web-vitals branch from dab56b4 to 51b4b3a Compare January 22, 2025 14:25
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@rafaeelaudibert rafaeelaudibert merged commit 0d30dd5 into master Jan 24, 2025
99 checks passed
@rafaeelaudibert rafaeelaudibert deleted the add-storybook-for-web-analytics-and-web-vitals branch January 24, 2025 10:19
timgl pushed a commit that referenced this pull request Jan 28, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants