-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Storybook snapshots for Web Analytics and Web Vitals #27709
feat: Add Storybook snapshots for Web Analytics and Web Vitals #27709
Conversation
Most of the stat numbers in those |
@robbie-c This is almost ready, I just need to figure out how can I restrict the width/height from some of these renders to guarantee that they look nicer in the website |
frontend/__snapshots__/web-analytics-dashboard--web-analytics-dashboard--light.png
Show resolved
Hide resolved
frontend/__snapshots__/web-analytics-dashboard--web-analytics-dashboard--dark.png
Show resolved
Hide resolved
frontend/__snapshots__/web-analytics-dashboard--web-analytics-dashboard--dark.png
Show resolved
Hide resolved
c9f21e5
to
386af42
Compare
Size Change: -766 B (-0.07%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
0830e50
to
f358b83
Compare
These are way overdue, so here we have some snapshots for UI regressions on Web Analytics
This is just too problematic when taking snapshots because it's hard to make the tooltip go away when we change to the next component
dab56b4
to
51b4b3a
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Changes
These are way overdue, so here we have some snapshots for UI regressions on Web Analytics and Web Vitals
Note
This might look like the
Trends
charts are not rendering and I have to fix this, but it's actually a known restriction we've self-imposed. See https://posthog.slack.com/archives/C02E3BKC78F/p1737501183808219. I'm working on changing that in a follow-up PR.In a follow-up PR, I'll attempt to automate copying these snapshots to the
posthog.com
repo to keep our product screenshots always up to date 🕺🏻Does this work well for both Cloud and self-hosted?
Not relevant
How did you test this code?
This is literally test code!