chore: refactor delete dag #27661
Open
chore: refactor delete dag #27661
+552
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuziontech
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes local storage dependencies from the person deletion DAG by implementing direct data piping between PostgreSQL and ClickHouse, making it more suitable for Kubernetes deployments.
- Added chunked processing in
/dags/deletes.pywith 10,000 record batches for efficient PostgreSQL to ClickHouse transfers - Implemented ClickHouse dictionary creation in
/dags/deletes.pyfor optimized person deletion lookups - Added comprehensive mocking of ClickHouse client in
/dags/tests/test_deletes.pyto verify direct database interactions - Introduced versioned table/dictionary naming with
get_versioned_names()for better cleanup and isolation - Added one-hour timeout setting for large deletion operations in
delete_person_eventsasset
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
dags/tests/test_deletes.py
Outdated
Comment on lines
70
to
75
| mock_clickhouse_client.execute.assert_called_once_with( | ||
| f""" | ||
| INSERT INTO {expected_names["table"]} (team_id, person_id, created_at) | ||
| VALUES | ||
| """, | ||
| expected_data, |
There was a problem hiding this comment.
logic: SQL query is missing VALUES clause formatting - could cause syntax error in ClickHouse. Should include parentheses around values.
There was a problem hiding this comment.
this had me second guessing myself
https://clickhouse-driver.readthedocs.io/en/latest/quickstart.html#inserting-data
* master: (103 commits) feat(postgres-estimated-rows): pg Estimated Rows on Data Warehouse Sync (#27634) fix: revert darkmode class toggle, updated content on fills (#27783) chore: upgrade posthog-js (#27790) chore(editor-3001): add back join actions (#27740) feat: Add person distinct ID overrides squash job (as dagster job) (#27710) fix(created-by-sources): Adding `created_by` to sources (#27751) Revert "feat(data-warehouse): V2 pipeline release " (#27791) fix: typo for feature flags (#27786) fix(defer-unmounting): Defer unmounting of react elements (#27742) feat(data-warehouse): V2 pipeline release (#27732) fix(data-warehouse): Ensure dates are actual datetime formats (#27777) fix: enable hot reload for the products dir (#27746) fix: assignee selector when null (#27737) chore: clarify rrweb imports (#27776) chore(deps): Update posthog-js to 1.207.3 (#27779) feat(retention): filters on start/return event (#27770) fix(experiments): only show supported math functions (#27589) feat(web-analytics): Set unique conversions graph when adding conversions goal (#27774) chore: color design system part 1: banner and accents (#27756) chore(experiments): Add tests for funnel attribution options (#27752) ...
fuziontech
changed the title
fuziontech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
no local storage
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?