Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more posthog props to taxonomy #27430

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Jan 10, 2025

we've added more props to posthog-js without adding them to the taxonomy, so they aren't hidden when we set "hide posthog properties"

well, not any more!

before after
Screenshot 2025-01-10 at 07 41 11 Screenshot 2025-01-10 at 07 45 58

@pauldambra pauldambra requested a review from veryayskiy January 10, 2025 07:40
Copy link
Contributor

Size Change: +809 B (+0.07%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +809 B (+0.07%)

compressed-size-action

Copy link
Contributor

@joshsny joshsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low context, looks great 🚀

@pauldambra pauldambra merged commit 7fdf640 into master Jan 10, 2025
99 checks passed
@pauldambra pauldambra deleted the fix/add-more-posthog-properties branch January 10, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants