Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use actions/{download,upload}-artifact@v4 #27413

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

rafaeelaudibert
Copy link
Member

This will stop working on or after January 30th. I've seen it fail in a couple of my PRs already, so they might be flaky already, let's migrate, I don't think there's anything that would prevent us from doing so, see migration guides:

This will stop working on or after January 30th. I've seen it fail in a couple of my PRs already, so they might be flaky already, let's migrate, I don't think there's anything that would prevent us from doing so, see migration guides:

- https://github.com/actions/upload-artifact#breaking-changes
- https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
@rafaeelaudibert rafaeelaudibert added the automerge Merge this PR automatically when REQUIRED checks pass label Jan 9, 2025
@rafaeelaudibert rafaeelaudibert enabled auto-merge (squash) January 9, 2025 18:07
@@ -112,7 +112,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Fetch wheels
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only download one, all others are upload

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@thmsobrmlr thmsobrmlr self-requested a review January 9, 2025 22:07
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@rafaeelaudibert rafaeelaudibert merged commit fa86162 into master Jan 9, 2025
103 checks passed
@rafaeelaudibert rafaeelaudibert deleted the move-to-download-upload-artifacts-v4 branch January 9, 2025 22:08
fuziontech added a commit that referenced this pull request Jan 10, 2025
* master: (659 commits)
  fix: more tz/date fiddling to get this property thing working (#27423)
  fix(hogql): support virtual tables with lazy tables (#27404)
  fix: Removing target options for survey resets its value to remove validation error (#27139)
  chore: Use `actions/{download,upload}-artifact@v4` (#27413)
  feat(clickhouse): when HTTP pass ca_cert and verify  to pool manager (#27399)
  fix: typo in dashboard template configuration (#27417)
  fix(experiments): Force refresh when `start_date` is provided (#27396)
  feat(data-warehouse): Reset the pipeline source files when resync is selected on the frontend (#27402)
  chore(data-warehouse): Added SSL error as a non retryable error (#27395)
  chore(data-warehouse): Upgrade deltalake package (#27393)
  chore(data-warehouse): Kill the delta subprocess if need be (#27392)
  feat: Add P75 quantile (#27409)
  fix: property labels need to be known about in the backend but are defined in the front end (#27328)
  fix(editor-3001): show header on mobile for editor (#27373)
  chore: Enable web vitals capture (#27394)
  feat: Add human friendly comparison periods toggle (#27176)
  feat: promote data warehouse from taxonomic filter component (#27364)
  chore(experiments): Improve result state resetting (#27391)
  fix: Track records completed in heartbeat (#26686)
  fix(data-warehouse): Handle NaN values from SQL sources (#27360)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR automatically when REQUIRED checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants