-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [1/2] access control capture (without test) #27031
Conversation
I see the failing test - I think I need mock the API calls for user permissions being changes first before checking if the capture is called. Will spend more time debugging this, but if anyone has suggestions please let me know! |
0785c04
to
b6c64f7
Compare
Since the tests were failing on origin and cannot be debugged locally, I'm separating the tests and capture log changes. I will add the tests in the following PR and follow up on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add tests to this asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't mean to approve. I thought about this more and we should get the test working on this PR. It should be possible. I'll try and debug it later in the week.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
im closing this PR and will follow up changes through this PR https://github.com/PostHog/posthog/actions/runs/12551899005/job/34997145853?pr=27142 |
Problem
We want to capture logs when the user toggles on/off access control feature under teams.
Remaining features include:
Changes
Changes only add logs in the backend, no frontend changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Cloud: Yes
How did you test this code?
Locally verified that the activity monitor showed the events and add tests