feat(cdp): site destination mapping templates #26866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
benjackwhite
approved these changes
Dec 12, 2024
| mappings=[], | ||
| mapping_templates=[ | ||
| HogFunctionMappingTemplate( | ||
| name="Aquisition", |
There was a problem hiding this comment.
Maybe we could have default: true or something for templates so that some can be applied by default to the mappings section on load (sort of like we do for the inputs schema
There was a problem hiding this comment.
Good idea. Got stuck behind naming things. I tried with just a default, but that made me want to add a # this means it'll be included by default when the function is created comment. So I went with include_by_default=True instead... which is hopefully unambiguous enough.
| ], | ||
| actions: [], | ||
| }, | ||
| <LemonLabel>New Mapping</LemonLabel> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to make it easy to subscribe to predefined mappings for destinations.
Changes
Adds "mapping templates"
How did you test this code?
In the browser for now