-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(batch-exports): Add batch export monitoring workflow #26728
Conversation
Hey @rossgray! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution and implementation look really good. I have a handful of comments to address scattered all over, but nothing critical.
4fd7d97
to
5f2e8ed
Compare
@tomasfarias thanks for the review! Think I've addressed all your feedback. Going to spend some more time investigating what's going on with this test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PR looks great. Once tests are passing this is good to merge! Good work!
5f2e8ed
to
70f3758
Compare
70f3758
to
456bc73
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
In the past we've had some issues with events missing from certain batch exports and lack any reliable monitoring for this.
Changes
Add a new workflow in Temporal for monitoring the events exported by a given team's batch export.
This workflow is quite specific at the moment, in that it just checks 5 min batch exports (since these are the only ones using the
recent_events
table). It checks for a previous hour's worth of events (based oninserted_at
) and stores the event count in thebatch_export_runs
table, so we can later reconcile this againstrecords_completed
.I have left a few TODOs in the code for things I'm unsure about.
Does this work well for both Cloud and self-hosted?
it doesn't have an impact
How did you test this code?
Added tests