fix: tune up tests for async deletes #24090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into delete_test_fixes * 'delete_test_fixes' of https://github.com/PostHog/posthog: (22 commits) chore(deps): Update posthog-js to 1.153.0 (#24113) fix: series with different current and previous breakdowns are throwing errors (#24092) chore(deps): Update posthog-js to 1.152.1 (#24110) fix(bi): Use a better tooltip mode for graphs (#24101) feat(bi): Added support for decimal numbers in BI (#24103) fix: Site app url for early access (#24104) feat(cdp): Added mailjet templates (#24096) fix: dry run output was inaccurate (#24075) feat: Add batch utilization metric for blobby (#24094) chore(deps): Update posthog-js to 1.151.2 (#24106) fix: limit metadata reloading (#24099) chore: remove useless draft files (#24102) feat(data-warehouse): Added the ability to use dashboard filters in BI queries (#24033) chore(deps): Update posthog-js to 1.151.1 (#24098) fix: Pipeline activity logs (#24077) feat(BI): Series settings (#24082) feat(dev): add separate env var for disabling navigation hooks (#24097) fix(web-analytics): Fix empty channel types (#24087) fix: Make error contact point to support modal (#24048) feat(notebooks): add error boundary around components (#24095) ...
tkaemming
approved these changes
Jul 31, 2024
|
|
||
| logger.debug(f"Query size: {query_size}") | ||
| logger.debug(f"Query: {query}") | ||
| logger.debug(f"Query deletions: {deletions}") | ||
|
|
||
| # If the query size is greater than the max predicate size, execute the query and reset the query predicate | ||
| if query_size > MAX_PREDICATE_SIZE: |
There was a problem hiding this comment.
Not sure what the maximum query length is offhand or how close this bumps into it so I'm not sure if this is useful or not, but it seems like it'd be safer if the query exceeds the predicate size to use the query from the last iteration, not this one after the limit is exceeded?
tkaemming
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
debuging issues with async deletes
Changes
improved logging and fixes for tests
Does this work well for both Cloud and self-hosted?
How did you test this code?