fix(editor-3001): show header on mobile for editor (#27373)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Jan 9, 2025 · e80bde2 · e80bde2
1 parent a2c85e2
commit e80bde2
Show file tree

Hide file tree

Showing 74 changed files with 5 additions and 5 deletions.
diff --git a/frontend/__snapshots__/posthog-3000-navigation--navigation-3000--dark.png b/frontend/__snapshots__/posthog-3000-navigation--navigation-3000--dark.png
diff --git a/frontend/__snapshots__/posthog-3000-navigation--navigation-3000--light.png b/frontend/__snapshots__/posthog-3000-navigation--navigation-3000--light.png
diff --git a/frontend/__snapshots__/replay-listings--recordings-play-lists--dark.png b/frontend/__snapshots__/replay-listings--recordings-play-lists--dark.png
diff --git a/frontend/__snapshots__/replay-listings--recordings-play-lists--light.png b/frontend/__snapshots__/replay-listings--recordings-play-lists--light.png
diff --git a/frontend/__snapshots__/replay-player-failure--recent-recordings-404--dark.png b/frontend/__snapshots__/replay-player-failure--recent-recordings-404--dark.png
diff --git a/frontend/__snapshots__/replay-player-failure--recent-recordings-404--light.png b/frontend/__snapshots__/replay-player-failure--recent-recordings-404--light.png
diff --git a/frontend/__snapshots__/replay-player-success--recent-recordings--dark.png b/frontend/__snapshots__/replay-player-success--recent-recordings--dark.png
diff --git a/frontend/__snapshots__/replay-player-success--recent-recordings--light.png b/frontend/__snapshots__/replay-player-success--recent-recordings--light.png
diff --git a/frontend/__snapshots__/replay-player-success--second-recording-in-list--dark.png b/frontend/__snapshots__/replay-player-success--second-recording-in-list--dark.png
diff --git a/frontend/__snapshots__/replay-player-success--second-recording-in-list--light.png b/frontend/__snapshots__/replay-player-success--second-recording-in-list--light.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--list--dark.png b/frontend/__snapshots__/scenes-app-dashboards--list--dark.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--list--light.png b/frontend/__snapshots__/scenes-app-dashboards--list--light.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--new--dark.png b/frontend/__snapshots__/scenes-app-dashboards--new--dark.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--new--light.png b/frontend/__snapshots__/scenes-app-dashboards--new--light.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--new-select-variables--dark.png b/frontend/__snapshots__/scenes-app-dashboards--new-select-variables--dark.png
diff --git a/frontend/__snapshots__/scenes-app-dashboards--new-select-variables--light.png b/frontend/__snapshots__/scenes-app-dashboards--new-select-variables--light.png
diff --git a/frontend/__snapshots__/scenes-app-events--event-explorer--dark.png b/frontend/__snapshots__/scenes-app-events--event-explorer--dark.png
diff --git a/frontend/__snapshots__/scenes-app-events--event-explorer--light.png b/frontend/__snapshots__/scenes-app-events--event-explorer--light.png
diff --git a/frontend/__snapshots__/scenes-app-feature-flags--feature-flags-list--dark.png b/frontend/__snapshots__/scenes-app-feature-flags--feature-flags-list--dark.png
diff --git a/frontend/__snapshots__/scenes-app-feature-flags--feature-flags-list--light.png b/frontend/__snapshots__/scenes-app-feature-flags--feature-flags-list--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--light.png
diff --git a/...s__/scenes-app-pipeline--pipeline-destinations-page-without-pipelines--dark.png b/...s__/scenes-app-pipeline--pipeline-destinations-page-without-pipelines--dark.png
diff --git a/...__/scenes-app-pipeline--pipeline-destinations-page-without-pipelines--light.png b/...__/scenes-app-pipeline--pipeline-destinations-page-without-pipelines--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-landing-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-landing-page--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-landing-page--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-landing-page--light.png
diff --git a/...shots__/scenes-app-pipeline--pipeline-landing-page-iff-legacy-sources--dark.png b/...shots__/scenes-app-pipeline--pipeline-landing-page-iff-legacy-sources--dark.png
diff --git a/...hots__/scenes-app-pipeline--pipeline-landing-page-iff-legacy-sources--light.png b/...hots__/scenes-app-pipeline--pipeline-landing-page-iff-legacy-sources--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-legacy-sources-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-legacy-sources-page--dark.png
diff --git a/...tend/__snapshots__/scenes-app-pipeline--pipeline-legacy-sources-page--light.png b/...tend/__snapshots__/scenes-app-pipeline--pipeline-legacy-sources-page--light.png
diff --git a/...nd/__snapshots__/scenes-app-pipeline--pipeline-node-configuration-404--dark.png b/...nd/__snapshots__/scenes-app-pipeline--pipeline-node-configuration-404--dark.png
diff --git a/...d/__snapshots__/scenes-app-pipeline--pipeline-node-configuration-404--light.png b/...d/__snapshots__/scenes-app-pipeline--pipeline-node-configuration-404--light.png
diff --git a/...d/__snapshots__/scenes-app-pipeline--pipeline-node-edit-configuration--dark.png b/...d/__snapshots__/scenes-app-pipeline--pipeline-node-edit-configuration--dark.png
diff --git a/.../__snapshots__/scenes-app-pipeline--pipeline-node-edit-configuration--light.png b/.../__snapshots__/scenes-app-pipeline--pipeline-node-edit-configuration--light.png
diff --git a/...cenes-app-pipeline--pipeline-node-edit-configuration-stateless-plugin--dark.png b/...cenes-app-pipeline--pipeline-node-edit-configuration-stateless-plugin--dark.png
diff --git a/...enes-app-pipeline--pipeline-node-edit-configuration-stateless-plugin--light.png b/...enes-app-pipeline--pipeline-node-edit-configuration-stateless-plugin--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-logs--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-logs--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-logs--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-logs--light.png
diff --git a/...nd/__snapshots__/scenes-app-pipeline--pipeline-node-logs-batch-export--dark.png b/...nd/__snapshots__/scenes-app-pipeline--pipeline-node-logs-batch-export--dark.png
diff --git a/...d/__snapshots__/scenes-app-pipeline--pipeline-node-logs-batch-export--light.png b/...d/__snapshots__/scenes-app-pipeline--pipeline-node-logs-batch-export--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-metrics--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-metrics--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-metrics--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-node-metrics--light.png
diff --git a/.../__snapshots__/scenes-app-pipeline--pipeline-node-metrics-error-modal--dark.png b/.../__snapshots__/scenes-app-pipeline--pipeline-node-metrics-error-modal--dark.png
diff --git a/...__snapshots__/scenes-app-pipeline--pipeline-node-metrics-error-modal--light.png b/...__snapshots__/scenes-app-pipeline--pipeline-node-metrics-error-modal--light.png
diff --git a/...end/__snapshots__/scenes-app-pipeline--pipeline-nodes-management-page--dark.png b/...end/__snapshots__/scenes-app-pipeline--pipeline-nodes-management-page--dark.png
diff --git a/...nd/__snapshots__/scenes-app-pipeline--pipeline-nodes-management-page--light.png b/...nd/__snapshots__/scenes-app-pipeline--pipeline-nodes-management-page--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-overview-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-overview-page--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-overview-page--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-overview-page--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-site-apps-page--light.png
diff --git a/...tend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png b/...tend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png
diff --git a/...end/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png b/...end/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png
diff --git a/..._snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--dark.png b/..._snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--dark.png
diff --git a/...snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--light.png b/...snapshots__/scenes-app-pipeline--pipeline-transformations-page-empty--light.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--card-view--dark.png b/frontend/__snapshots__/scenes-app-saved-insights--card-view--dark.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--card-view--light.png b/frontend/__snapshots__/scenes-app-saved-insights--card-view--light.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--empty-state--dark.png b/frontend/__snapshots__/scenes-app-saved-insights--empty-state--dark.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--empty-state--light.png b/frontend/__snapshots__/scenes-app-saved-insights--empty-state--light.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--list-view--dark.png b/frontend/__snapshots__/scenes-app-saved-insights--list-view--dark.png
diff --git a/frontend/__snapshots__/scenes-app-saved-insights--list-view--light.png b/frontend/__snapshots__/scenes-app-saved-insights--list-view--light.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-activation--dark.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-activation--dark.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-activation--light.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-activation--light.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--dark.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--dark.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-notebooks--dark.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-notebooks--dark.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-notebooks--light.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-notebooks--light.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-settings--dark.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-settings--dark.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-settings--light.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-settings--light.png
diff --git a/...tend/__snapshots__/scenes-app-sidepanels--side-panel-support-no-email--dark.png b/...tend/__snapshots__/scenes-app-sidepanels--side-panel-support-no-email--dark.png
diff --git a/...end/__snapshots__/scenes-app-sidepanels--side-panel-support-no-email--light.png b/...end/__snapshots__/scenes-app-sidepanels--side-panel-support-no-email--light.png
diff --git a/...nd/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--dark.png b/...nd/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--dark.png
diff --git a/...d/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--light.png b/...d/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--light.png
diff --git a/frontend/src/layout/navigation-3000/Navigation.scss b/frontend/src/layout/navigation-3000/Navigation.scss
@@ -238,8 +238,6 @@
 }
 
 .Sidebar3000__content {
-    position: fixed;
-    top: 0;
     box-sizing: content-box;
     display: flex;
     flex-direction: column;

diff --git a/frontend/src/layout/navigation-3000/Navigation.tsx b/frontend/src/layout/navigation-3000/Navigation.tsx
@@ -48,7 +48,7 @@ export function Navigation({
                 {activeNavbarItem && <Sidebar key={activeNavbarItem.identifier} navbarItem={activeNavbarItem} />}
             </FlaggedFeature>
             <main>
-                {sceneConfig?.layout !== 'app-raw-no-header' && <TopBar />}
+                {(sceneConfig?.layout !== 'app-raw-no-header' || mobileLayout) && <TopBar />}
                 <div
                     className={clsx(
                         'Navigation3000__scene',
@@ -58,8 +58,10 @@ export function Navigation({
                         sceneConfig?.layout === 'app-canvas' && 'Navigation3000__scene--canvas'
                     )}
                 >
-                    {!sceneConfig?.hideBillingNotice && <BillingAlertsV2 />}
-                    {!sceneConfig?.hideProjectNotice && <ProjectNotice />}
+                    <div className={sceneConfig?.layout === 'app-raw-no-header' ? 'px-4' : ''}>
+                        {!sceneConfig?.hideBillingNotice && <BillingAlertsV2 />}
+                        {!sceneConfig?.hideProjectNotice && <ProjectNotice />}
+                    </div>
                     {children}
                 </div>
             </main>