feat(trends): use hogql for legacy insight trends api (#27213)

PostHog · Jan 13, 2025 · 1720839 · 1720839
1 parent 69893a1
commit 1720839
Show file tree

Hide file tree

Showing 15 changed files with 1,105 additions and 1,420 deletions.
diff --git a/ee/clickhouse/views/test/__snapshots__/test_clickhouse_stickiness.ambr b/ee/clickhouse/views/test/__snapshots__/test_clickhouse_stickiness.ambr
diff --git a/ee/clickhouse/views/test/__snapshots__/test_clickhouse_trends.ambr b/ee/clickhouse/views/test/__snapshots__/test_clickhouse_trends.ambr
diff --git a/ee/clickhouse/views/test/funnel/test_clickhouse_funnel_correlation.py b/ee/clickhouse/views/test/funnel/test_clickhouse_funnel_correlation.py
@@ -117,6 +117,7 @@ def test_event_correlation_endpoint_picks_up_events_for_odds_ratios(self):
                 ],
                 "skewed": False,
             },
+            "query_method": "hogql",
         }
 
     def test_event_correlation_is_partitioned_by_team(self):
@@ -217,6 +218,7 @@ def test_event_correlation_endpoint_does_not_include_historical_events(self):
             "is_cached": False,
             "last_refresh": "2020-01-01T00:00:00Z",
             "result": {"events": [], "skewed": False},
+            "query_method": "hogql",
         }
 
     def test_event_correlation_endpoint_does_not_include_funnel_steps(self):
@@ -278,6 +280,7 @@ def test_event_correlation_endpoint_does_not_include_funnel_steps(self):
                 ],
                 "skewed": False,
             },
+            "query_method": "hogql",
         }
 
     def test_events_correlation_endpoint_provides_people_drill_down_urls(self):
@@ -597,6 +600,7 @@ def test_correlation_endpoint_request_with_no_steps_doesnt_fail(self):
             "is_cached": False,
             "last_refresh": "2020-01-01T00:00:00Z",
             "result": {"events": [], "skewed": False},
+            "query_method": "hogql",
         }
 
     def test_funnel_correlation_with_event_properties_autocapture(self):
@@ -682,6 +686,7 @@ def test_funnel_correlation_with_event_properties_autocapture(self):
             },
             "last_refresh": "2020-01-01T00:00:00Z",
             "is_cached": False,
+            "query_method": "hogql",
         }
 
         assert get_people_for_correlation_ok(client=self.client, correlation=response["result"]["events"][0]) == {

diff --git a/ee/clickhouse/views/test/test_clickhouse_stickiness.py b/ee/clickhouse/views/test/test_clickhouse_stickiness.py
@@ -79,7 +79,7 @@ def test_filter_by_group_properties(self):
             properties={},
         )
 
-        p1, p2, p3, p4 = self._create_multiple_people(
+        self._create_multiple_people(
             period=timedelta(weeks=1),
             event_properties=lambda i: {
                 "$group_0": f"org:{i}",
@@ -112,15 +112,6 @@ def test_filter_by_group_properties(self):
         assert data["watched movie"][2].value == 0
         assert data["watched movie"][3].value == 1
 
-        with freeze_time("2020-02-15T13:01:01Z"):
-            week1_actors = get_people_from_url_ok(self.client, data["watched movie"][1].person_url)
-            week2_actors = get_people_from_url_ok(self.client, data["watched movie"][2].person_url)
-            week3_actors = get_people_from_url_ok(self.client, data["watched movie"][3].person_url)
-
-        assert sorted([p["id"] for p in week1_actors]) == sorted([str(p1.uuid)])
-        assert sorted([p["id"] for p in week2_actors]) == sorted([])
-        assert sorted([p["id"] for p in week3_actors]) == sorted([str(p3.uuid)])
-
     @snapshot_clickhouse_queries
     def test_aggregate_by_groups(self):
         create_group(
@@ -169,15 +160,6 @@ def test_aggregate_by_groups(self):
         assert data["watched movie"][2].value == 0
         assert data["watched movie"][3].value == 1
 
-        with freeze_time("2020-02-15T13:01:01Z"):
-            week1_actors = get_people_from_url_ok(self.client, data["watched movie"][1].person_url)
-            week2_actors = get_people_from_url_ok(self.client, data["watched movie"][2].person_url)
-            week3_actors = get_people_from_url_ok(self.client, data["watched movie"][3].person_url)
-
-        assert sorted([p["id"] for p in week1_actors]) == sorted(["org:0", "org:2"])
-        assert sorted([p["id"] for p in week2_actors]) == sorted([])
-        assert sorted([p["id"] for p in week3_actors]) == sorted(["org:1"])
-
     @snapshot_clickhouse_queries
     def test_timezones(self):
         journeys_for(