feat: Add a onPreviewSubmit callback to preview surveys #1641
+192
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +3.86 kB (+0.12%) Total Size: 3.23 MB
ℹ️ View Unchanged
|
rafaeelaudibert
approved these changes
Jan 6, 2025
| const surveyPreviewRef = useRef<HTMLDivElement>(null) | ||
| const [currentPageIndex, setCurrentPageIndex] = useState(0) | ||
|
|
||
| console.log('Current page index:', currentPageIndex) |
There was a problem hiding this comment.
Do we need this log here?
There was a problem hiding this comment.
We might want to add a linter to forbid this
src/extensions/surveys.tsx
Outdated
| @@ -618,6 +627,7 @@ export function Questions({ | |||
| originalQuestionIndex, | |||
| displayQuestionIndex, | |||
| }), | |||
| onPreviewSubmit: (res) => onPreviewSubmit(res), | |||
There was a problem hiding this comment.
Suggested change
| onPreviewSubmit: (res) => onPreviewSubmit(res), | |
| onPreviewSubmit, |
There was a problem hiding this comment.
thanks updated both!
|
Not sure if the team has let you known how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new
onPreviewSubmitparameter torenderSurveysPreview.The main usage of
renderSurveysPreviewis on posthog internal website to demo surveys.By adding this callback, it allow us to call arbitrary functions after pressing the submit button in the survey.
It'll be used to fix this issue: PostHog/posthog#23650 and allow us to move to the next question after clicking the submit button.
...
Checklist