Merge pull request #13 from Portkey-Wallet/certik-audit-fix

Certik audit fix
Portkey-Wallet · Sep 10, 2024 · a90c6ef · a90c6ef
2 parents bb83ca2 + 0a544a7
commit a90c6ef
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/circuits/idHashMapping.circom b/circuits/idHashMapping.circom
@@ -7,7 +7,6 @@ template IdHashMapping(maxSubLen, maxSaltLen){
     signal input sub[maxSubLen];
     signal input subLen;
     signal input salt[maxSaltLen];
-    signal input saltLen;
     component poseidonHasher = IdHashPoseidon(maxSubLen, maxSaltLen);
 
     poseidonHasher.sub <== sub;

diff --git a/circuits/zkLogin.circom b/circuits/zkLogin.circom
@@ -12,11 +12,6 @@ template ZkLogin(maxHeaderLen, maxPaddedUnsignedJWTLen){
   var maxWhiteSpaceLen = 2; // actually we don't need this
   var maxSubClaimLen = maxSubNameLen + maxSubValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct 
 
-  var maxExpLen = 10;
-  var maxExpNameLen = 5;
-  var maxExpValueLen = maxExpLen;
-  var maxExpClaimLen = maxExpNameLen + maxExpValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct
-
   var maxNonceLen = 64;
   var maxNonceNameLen = 7;
   var maxNonceValueLen = maxNonceLen + 2; // 2 for double quotes

diff --git a/circuits/zkLoginSha256.circom b/circuits/zkLoginSha256.circom
@@ -12,11 +12,6 @@ template ZkLoginSha256(maxHeaderLen, maxPaddedUnsignedJWTLen){
   var maxWhiteSpaceLen = 2; // actually we don't need this
   var maxSubClaimLen = maxSubNameLen + maxSubValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct 
 
-  var maxExpLen = 10;
-  var maxExpNameLen = 5;
-  var maxExpValueLen = maxExpLen;
-  var maxExpClaimLen = maxExpNameLen + maxExpValueLen + maxWhiteSpaceLen; // TODO: Check if this calculation is correct
-
   var maxNonceLen = 64;
   var maxNonceNameLen = 7;
   var maxNonceValueLen = maxNonceLen + 2; // 2 for double quotes

diff --git a/tests/idHashMapping.test.ts b/tests/idHashMapping.test.ts
@@ -52,7 +52,6 @@ describe("Id Hash Mapping Test", () => {
         ),
         subLen: 21,
         salt: Array.from(hexToBytes("a677999396dc49a28ad6c9c242719bb3"), (b) => b),
-        saltLen: 16
       };
       // will be packed into [13846356912322354, 85189581377597132177622858375434543549286969422497087616931493135530328064, 0,0,0,0,0,0,0]