Skip to content

Commit

Permalink
Revert "Introduced aspect ratio parameter for rectangle area"
Browse files Browse the repository at this point in the history
  • Loading branch information
chirgwin committed Dec 9, 2014
1 parent 91a28a0 commit f1c6777
Show file tree
Hide file tree
Showing 9 changed files with 193 additions and 564 deletions.
50 changes: 24 additions & 26 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,33 +1,32 @@
# Windows image file caches
Thumbs.db
ehthumbs.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# =========================
# Operating System Files
# =========================

# OSX
# =========================

# Windows image file caches
Thumbs.db
ehthumbs.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# =========================
# Operating System Files
# =========================

# OSX
# =========================

.DS_Store
.AppleDouble
.LSOverride

# Icon must ends with two \r.
Icon

Icon

# Thumbnails
._*
Expand All @@ -39,7 +38,6 @@ Icon

# SASS Cache
.sass_cache/
.sass-cache/

# Installed Bower/Node modules
bower_components/
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,7 @@ Assignable angular expression to data-bind to. NgImgCrop puts a data uri of a cr

### area-type

*Optional*. Type of the crop area. Possible values: circle|square|rectangle. Default: circle.

### aspect-ratio

*Optional*. Customizable aspect ratio for rectangle area type. Possible values: decimal. Default: none.
*Optional*. Type of the crop area. Possible values: circle|square. Default: circle.

### area-min-size

Expand Down
2 changes: 1 addition & 1 deletion compile/minified/ng-img-crop.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion compile/minified/ng-img-crop.js

Large diffs are not rendered by default.

Loading

3 comments on commit f1c6777

@aluminiumgeek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@chirgwin
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aluminiumgeek It was buggy. See this dicussion for more details. This covers rectangle cropping without arbitrary aspect ratios. Arbitrary aspect ratios are covered by this issue and should ideally be a discrete pull request directly against the upstream repository.

@aluminiumgeek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirgwin ok, I got it.

Please sign in to comment.