Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Listener tried to modify its DOM in the constructor #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inureyes
Copy link

Bug

  • Original code worked until Polymer 2.3.1. Since Polymer 2.4.0, Current paper-toggle-button does not work with error
Uncaught DOMException: Failed to construct 'CustomElement': The result must not have attributes

Reason

Solution

  • Can be solved by moving the listener binding to the attached.

…nstructor.

  - The element's attributes and children must not be inspected, as in the non-upgrade case none will be present, and relying on upgrades makes the element less usable
@llowrey
Copy link

llowrey commented Feb 18, 2019

Thank you for this patch! I'm surprised this is still an issue one year later. It would be good to see a v3.0.2 that includes this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants