Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on mac linux #48

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

josephwoodward
Copy link
Contributor

@josephwoodward josephwoodward commented Aug 20, 2019

A PR to add the full framework reference assemblies so I can build the Simmy solution on Mac or Linux. I've also added Rider to the .gitignore file.

Tests now pass on Mac/Linux.

Screenshot 2019-08-20 at 03 04 43

@vany0114
Copy link
Member

That's a great idea @josephwoodward, thanks for the contribution!

Could you change the target branch to v0_2_1, please? I'd like to release your changes there together whit this guy: #46 btw if you want to pick that up, would be very helpful too :)

@josephwoodward josephwoodward changed the base branch from master to v0_2_1 August 20, 2019 16:51
@josephwoodward
Copy link
Contributor Author

josephwoodward commented Aug 20, 2019

Target branch has now been set to v0_2_1.

Sure, happy to look at #46. I'll create a separate PR for it.

@vany0114 vany0114 added this to the V0.2.1 milestone Aug 20, 2019
@vany0114 vany0114 self-requested a review August 20, 2019 23:42
@vany0114 vany0114 merged commit d51aa4c into Polly-Contrib:v0_2_1 Aug 20, 2019
@josephwoodward josephwoodward deleted the CompileOnMacLinux branch August 21, 2019 02:55
@vany0114 vany0114 mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants