Hisui #95

anhthang · 2022-03-02T04:08:57Z

I have added some new data for the new Pokemon and new forms introduced in Legends: Arceus

All of this data was collected manually from Bulbapedia (Japanese collected from Zukan)

Not sure what I'm doing is in the right way, or missing anything, so please help me verify if possible, then I can continue and correct it.

…ulin

Naramsim · 2022-03-04T20:01:25Z

Hi @anhthang, sorry for the extremely late reply. Thanks infinitely for the additions. I'll have to review a bit the PR and understand how the new update works.

If I understood correctly this data is from the Arceus update, right? So we are still talking about gen 8?

anhthang · 2022-03-05T01:31:40Z

Hi @Naramsim

Yes, this is gen 8 update from Arceus. So, please review it.

I also find out that some old pokemon has forms (cherrim, shellos, gastrodon, deerling, sawsbuck...), but they're missing pokemon/species id so it's missing in the API too. How we can add it safely? I thought it should be in a order like pokemon_id, is it?

simonorono · 2022-04-10T13:13:43Z

This is great @anhthang I noticed that the new Pokédex from Hisui, the addition of new Pokémon to the national dex and new moves/learn-sets is missing. Would that block the merging of this PR or can be contributed later? @Naramsim

I could help with those.

anhthang · 2022-04-10T14:58:28Z

Thanks @simonorono. I'm still waiting feedback from @Naramsim before adding the others. New moves, TM/HM... maybe in another PR.

Naramsim · 2022-04-10T20:17:07Z

I don't have any time to look into it guys. I'm sorry this has taken ages. Hopefully, I'll reserve some time and try to understand the new generation and the new data. But if there are other core members who are willing to review, then it might be way quicker.

Naramsim · 2022-04-10T20:18:02Z

If you want we could test this data in our staging environment. Could you open an identical PR towards the staging branch of PokeAPI?

pokedex/data/csv/versions.csv

anhthang · 2022-05-15T11:47:02Z

Hi @Naramsim,

Versions & version groups are updated, pls verify again if you have time.

I also have a question, why some pokemon has forms but they don't have a pokemon_id (like Cherrim, Unown...)

Naramsim · 2022-05-16T20:33:40Z

Hi @anhthang , thanks so much again! Imho, we can merge. @C-Garza any thoughts?

About the forms: there are forms and varieties. I forgot where the issue describing them is. I should pin it when I find it again.

C-Garza · 2022-05-17T08:19:35Z

Sorry, I haven't had time to look at this. I actually didn't notice this PR until you pinged me 😅. I can probably take a look at it tomorrow if you haven't already merged it by then.

anhthang · 2022-05-17T10:07:08Z

just fixed the flavor texts, break lines and sort

C-Garza · 2022-05-23T05:31:55Z

pokedex/data/csv/pokemon_species_flavor_text.csv

+484,39,9,"This Pokémon is feared as a deity in Hisuian legend. The birth
+of Palkia was what caused the walls of our world to disappear,
+creating a sky that spans for infinity."
+484,39,9,"It soars across the sky in a form that greatly resembles the
+creator of all things. Perhaps this imitation of appearance is
+Palkia's strategy for gaining Arceus's powers."


I see two flavor texts for the same entry. I'm assuming this pokemon has an additional entry for a form or something. I remember there being an issue about this before and the way it was resolved was for now was removing the form's entry. Same thing for id 483 and 905.
Found the old issue

Thanks for addressing that. I have removed just now.

C-Garza · 2022-05-23T05:40:05Z

I left one comment, other than that it looks good to me.

Naramsim · 2022-05-23T07:30:50Z

Nice, I'll try build pokeapi with this data later

Naramsim · 2022-05-24T20:17:20Z

pokedex/data/csv/pokemon_species.csv

@@ -897,3 +897,10 @@ id,identifier,generation_id,evolves_from_species_id,evolution_chain_id,color_id,
 896,glastrier,8,,474,9,8,,-1,3,35,0,120,0,1,0,1,0,896,
 897,spectrier,8,,475,1,8,,-1,3,35,0,120,0,1,0,1,0,897,
 898,calyrex,8,,476,5,12,,-1,3,100,0,120,0,1,0,1,0,898,
+899,wyrdeer,8,234,,4,,,4,,,0,,,1,,0,0,899,


Hi, here the data lacks information. By building the DB I get that:

null value in column "forms_switchable" of relation "pokemon_v2_pokemonspecies" violates not-null constraint

I guess we should try to fill all the columns.

Here the build: https://app.circleci.com/pipelines/github/PokeAPI/pokeapi/511/workflows/19090bb7-cda9-40cb-8187-9002a65fca2a/jobs/1228

@Naramsim updated in last commit

Naramsim

Nice thanks!

Naramsim · 2022-05-24T20:17:43Z

pokedex/data/csv/pokemon_species.csv

@@ -897,3 +897,10 @@ id,identifier,generation_id,evolves_from_species_id,evolution_chain_id,color_id,
 896,glastrier,8,,474,9,8,,-1,3,35,0,120,0,1,0,1,0,896,
 897,spectrier,8,,475,1,8,,-1,3,35,0,120,0,1,0,1,0,897,
 898,calyrex,8,,476,5,12,,-1,3,100,0,120,0,1,0,1,0,898,
+899,wyrdeer,8,234,,4,,,4,,,0,,,1,,0,0,899,


Here the build: https://app.circleci.com/pipelines/github/PokeAPI/pokeapi/511/workflows/19090bb7-cda9-40cb-8187-9002a65fca2a/jobs/1228

pokedex/data/csv/pokemon_species_flavor_text.csv

Naramsim · 2022-06-22T09:52:11Z

Yay! It's working!

Naramsim · 2022-06-22T09:53:03Z

Can you test a bit? https://staging.pokeapi.co/api/v2/pokemon/?offset=0&limit=200000 @anhthang

anhthang · 2022-06-22T10:15:56Z

@Naramsim I just fixed a small bug. I think the other is fine to me

PokeAPI/pokedex@6cb752f PokeAPI/pokedex#104 PokeAPI/pokedex#95

Naramsim · 2022-06-23T18:01:27Z

@anhthang, it's live! Thank you so much for the effort in these months. I know I took quite a while, but we maintainers don't have much time anymore.

Thanks again!

anhthang · 2022-06-24T03:05:15Z

@Naramsim thank you for your support 💪 can you update graphql also? it seems not updated

Naramsim · 2022-06-24T07:12:51Z

Ahhh, hahah yeahh, I'll try!!!

Naramsim · 2022-07-06T14:25:51Z

I've updated the graphql, can you check?

anhthang · 2022-07-06T15:20:26Z

I've updated the graphql, can you check?

Just tested, it seems working fine except some optional data. I will work on it later if I have time

bdawg1989 · 2023-06-23T18:23:18Z

Was this ever merged and fixed? All of the Hisui mons don't have gen 8 learnsets or moves that I can pull.

Naramsim · 2023-06-24T10:25:21Z

Yes this was merged

anhthang added 5 commits March 2, 2022 02:08

feat: adding new gen 8 data from Legends: Arceus

1d73943

feat: adding 16 new hisuian forms, new forms for dialga, palkia, basc…

f8d48fc

…ulin

feat: add pokemon forms

8ffb6e2

fix: update Basculegion Female, Enamorus Therian

6bd29fa

feat: add pokemon name in ko,fr,de. version name in other languages

897ec35

fix: gender rate

d24039d

Naramsim suggested changes May 4, 2022

View reviewed changes

pokedex/data/csv/versions.csv Outdated Show resolved Hide resolved

anhthang added 2 commits May 7, 2022 12:09

Merge branch 'master-pokeapi' into hisui

5ae01ee

fix: update versions, version groups

1cb7a6d

Naramsim approved these changes May 16, 2022

View reviewed changes

fix: flavor text

960a2d1

anhthang mentioned this pull request May 17, 2022

Missing Hisui Gen 8 data #89

Open

anhthang marked this pull request as ready for review May 20, 2022 02:44

C-Garza reviewed May 23, 2022

View reviewed changes

fix: remove additional flavor text

21cb732

Naramsim added a commit to PokeAPI/pokeapi that referenced this pull request May 24, 2022

sync: PokeAPI/pokedex#95

556720a

Naramsim reviewed May 24, 2022

View reviewed changes

fix: update shape_id, has_gender_differences, forms_switchable

dcab074

feat: add missing flavor text

5f24c48

Naramsim reviewed May 25, 2022

View reviewed changes

Naramsim added a commit to PokeAPI/pokeapi that referenced this pull request May 25, 2022

sync: PokeAPI/pokedex#95

4de4583

Naramsim reviewed May 26, 2022

View reviewed changes

pokedex/data/csv/pokemon_species_flavor_text.csv Show resolved Hide resolved

anhthang added 4 commits May 26, 2022 17:45

fix: double quotes

5caf8e2

fix: add form order

1f194f7

feat: add version names for newly added versions

77fb639

fix: add missing form order

1fe327a

fix: overqwil ability

3ccd8c5

fix: trim space

c142c8f

Naramsim merged commit 3530bc7 into PokeAPI:master-pokeapi Jun 22, 2022

Naramsim added a commit to PokeAPI/pokeapi that referenced this pull request Jun 22, 2022

sync:

e5f6477

PokeAPI/pokedex@6cb752f PokeAPI/pokedex#104 PokeAPI/pokedex#95

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hisui #95

Hisui #95

anhthang commented Mar 2, 2022

Naramsim commented Mar 4, 2022

anhthang commented Mar 5, 2022

simonorono commented Apr 10, 2022

anhthang commented Apr 10, 2022

Naramsim commented Apr 10, 2022

Naramsim commented Apr 10, 2022

anhthang commented May 15, 2022

Naramsim commented May 16, 2022

C-Garza commented May 17, 2022

anhthang commented May 17, 2022

C-Garza May 23, 2022

anhthang May 23, 2022

C-Garza commented May 23, 2022

Naramsim commented May 23, 2022

Naramsim May 24, 2022

Naramsim May 24, 2022

anhthang May 25, 2022

Naramsim left a comment

Naramsim May 24, 2022

Naramsim commented Jun 22, 2022

Naramsim commented Jun 22, 2022 •

edited

Loading

anhthang commented Jun 22, 2022

Naramsim commented Jun 23, 2022

anhthang commented Jun 24, 2022

Naramsim commented Jun 24, 2022

Naramsim commented Jul 6, 2022

anhthang commented Jul 6, 2022

bdawg1989 commented Jun 23, 2023

Naramsim commented Jun 24, 2023

Hisui #95

Hisui #95

Conversation

anhthang commented Mar 2, 2022

Naramsim commented Mar 4, 2022

anhthang commented Mar 5, 2022

simonorono commented Apr 10, 2022

anhthang commented Apr 10, 2022

Naramsim commented Apr 10, 2022

Naramsim commented Apr 10, 2022

anhthang commented May 15, 2022

Naramsim commented May 16, 2022

C-Garza commented May 17, 2022

anhthang commented May 17, 2022

C-Garza May 23, 2022

Choose a reason for hiding this comment

anhthang May 23, 2022

Choose a reason for hiding this comment

C-Garza commented May 23, 2022

Naramsim commented May 23, 2022

Naramsim May 24, 2022

Choose a reason for hiding this comment

Naramsim May 24, 2022

Choose a reason for hiding this comment

anhthang May 25, 2022

Choose a reason for hiding this comment

Naramsim left a comment

Choose a reason for hiding this comment

Naramsim May 24, 2022

Choose a reason for hiding this comment

Naramsim commented Jun 22, 2022

Naramsim commented Jun 22, 2022 • edited Loading

anhthang commented Jun 22, 2022

Naramsim commented Jun 23, 2022

anhthang commented Jun 24, 2022

Naramsim commented Jun 24, 2022

Naramsim commented Jul 6, 2022

anhthang commented Jul 6, 2022

bdawg1989 commented Jun 23, 2023

Naramsim commented Jun 24, 2023

Naramsim commented Jun 22, 2022 •

edited

Loading