Adding LGPE move names

[AndreArrebola]

Info taken from Bulbapedia:
https://bulbapedia.bulbagarden.net/wiki/List_of_moves_in_other_languages

[Naramsim]

Hi @AndreArrebola,

I noted that on Bulbapedia there are moves up to ID 796. I'm just wondering why you stopped at 742

[AndreArrebola]

Hi! Due to time constraints I only could add the LGPE new moves yesterday. I might add the Sword/Shield moves when I have time, though!
Do you think this can be merged already and then I add them in a future request, or do you prefer to wait until all moves are added?

[Naramsim]

Did you add them by hand?

I thought you used a script 👍

Then no worries at all!

[AndreArrebola]

Yes, I did it by hand! it's how I can help for now
I'm using this as an opportunity to learn pull requests with GitHub

So, just to confirm, this will be merged and then when I(or other contributor) are able to contribute with the SwSh movenames this will be added in another pull request, right?

[Naramsim]

Hi, I was thinking to merge your branch in staging to check if it deploys correctly, then I'll merge it in master.

[Naramsim]

Feel free to push to this branch up until it has been merged.

[AndreArrebola]

Hello, during the day I adapted the stats script to fetch the move languages and informations from bulbapedia using the API. It worked out very well, good job on making the original one!
I also added a way to generate a csv out of it, but it only works right with the move languages. This happens because the move table in pokeapi uses IDs for infos like types.

Do you think making a json associating these infos to their IDs(and then replacing them as they're fetched) would work?
For example, if it gets "Normal" from Bulbapedia, the script could search for that in the json file and get the respective ID, replacing the value in the data with it
(I have job tomorrow so I might not be able to work on it before thursday!)

[Naramsim]

Hi, I've seen that you generated a new newmoves.json file. That's great! And no need to add automatically all these new moves to the moves.csv file, we can copy and paste them. Anyway, I've seen that your CSV is a bit different from the original one:

Original moves.csv

id,identifier,generation_id,type_id,power,pp,accuracy,priority,target_id,damage_class_id,effect_id,effect_chance,contest_type_id,contest_effect_id,super_contest_effect_id
728,clangorous-soulblaze,7,16,185,1,,0,11,3,419,100,,,

Your newmoves.csv looks like below:

729,VII,Electric,Zippy_Zap,50,15,100,+2,anyadjacent,Physical

But it should be: (as you did manually)

729,zippy-zap,7,13,50,15,100,2,10,2,289,,,,

So basically we need the very same format. If you need to get the IDs of some resources you can look them up in pokeapi.co.

[AndreArrebola]

Forgot to change the order, I'll do it as soon as I have time, be it today or tomorrow!
And get the ids from the api too

[Naramsim]

Thanks a lot, and please take your time. Don't rush :P

[AndreArrebola]

Hello again! I tweaked the script so it generated the csv in the proper format :) I added the type/generation/damage type ids in json files since they are pretty much constant
I still didn't add the new lines to the csv, I just want you to take a look on it first. The results look promising though! I might add a way to generate the flags too

[Naramsim]

Excellent @AndreArrebola, thanks so much! Feel free to update all the official CSV files in /pokedex/data/csv/ so we can merge. You can add the new lines manually, no need to have the script doing it.

[AndreArrebola]

Commited the changes! Sorry for the wait.