Remove global includes from PCL_SUBSYS_DEPEND in PCL_TARGETS and adjust accordingly #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
changed the title
larshg
force-pushed
the
updateall
branch
2 times, most recently
from
68ecf25 to
9288783
Compare
larshg
force-pushed
the
updateall
branch
5 times, most recently
from
1db98c8 to
35076b9
Compare
larshg
force-pushed
the
updateall
branch
2 times, most recently
from
437bbbe to
1decaef
Compare
mvieth
reviewed
Jan 25, 2025
| @@ -16,7 +16,7 @@ PCL_ADD_TEST(registration_warp_api test_warps | |||
|
|
|||
| PCL_ADD_TEST(correspondence_estimation test_correspondence_estimation | |||
| FILES test_correspondence_estimation.cpp | |||
| LINK_WITH pcl_gtest pcl_registration pcl_features) | |||
| LINK_WITH pcl_gtest pcl_io pcl_registration pcl_features) | |||
There was a problem hiding this comment.
I assume this change (and the one above with PCL_SET_TEST_DEPENDENCIES) are necessary because test_correspondence_estimation.cpp includes pcd_io.h? It seems like including pcd_io.h is not actually necessary there, so we can instead remove that include and leave this CMakeLists.txt unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.