Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-1594: Fix English title apostrophe formatting #1224

Merged

Conversation

katerinachinnappan
Copy link
Contributor

@katerinachinnappan katerinachinnappan commented Nov 18, 2024

Goal

Fix the apostrophe formatting for English titles. Currently, words with an apostrophe + 1 letter following the apostrophe have been formatted correctly:bat'S -> bat's.

Words with 2+ letters following an apostrophe were not formatted correctly: you'll -> You'Ll.
Desired output: you'll -> You'll

Todos

  • deploy to dev

Reference

Tickets:

@katerinachinnappan katerinachinnappan requested a review from a team as a code owner November 18, 2024 22:27
Copy link
Collaborator

@jpetto jpetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many edge cases when formatting strings!

@katerinachinnappan katerinachinnappan merged commit f6798c9 into main Nov 19, 2024
10 checks passed
@katerinachinnappan katerinachinnappan deleted the katerina/MC-1594-fix-english-title-formatting branch November 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants