MC-1556: Ensure ‘Coronavirus’ is not available as a Topic when adding an Item #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ describe('helper functions related to topics', () => { | |||
|
|
|||
| it('returns a full list of topics if requested', () => { | |||
| const topics = getGroupedTopicData(data); | |||
| expect(topics).to.be.an('array').with.lengthOf(17); | |||
| expect(topics).to.be.an('array').with.lengthOf(16); | |||
There was a problem hiding this comment.
should I get rid of the 'returns a list of topics without "Coronavirus" if requested' test case as we don't show this topic?
There was a problem hiding this comment.
I think we should if this topic is no longer present anywhere in the rest of the codebase now!
nina-py
previously approved these changes
Oct 30, 2024
nina-py
approved these changes
Oct 30, 2024
katerinachinnappan
deleted the
katerina/MC-1556-remove-coronavirus-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Upon adding, editing an item, ensure "Coronavirus" is not in the Topics list. For existing items with "Coronavirus" topic, the topic will be displayed as "N/A"
Todos
Reference
Tickets: