Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(corpus): [MC-1446] Add new 'Publisher Request' rejection reason #1216

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Sep 6, 2024

Goal

Add the new rejection reason (Publisher Request) to Curation Tools frontend so that curators can start using it where necessary.

Testing: I have verified it works after deploying the backend change to Dev.

Follow-up

There are two more reasons available on the backend that we're NOT using on the frontend. These are COMMERCIAL and PUBLISHER_QUALITY. Should we add them, too?

Screenshots

new-rejection-reason

Reference

https://mozilla-hub.atlassian.net/browse/MC-1446

@nina-py nina-py requested a review from a team as a code owner September 6, 2024 11:46
Copy link
Collaborator

@jpetto jpetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡

@jpetto
Copy link
Collaborator

jpetto commented Sep 6, 2024

There are two more reasons available on the backend that we're NOT using on the frontend. These are COMMERCIAL and PUBLISHER_QUALITY. Should we add them, too?

good catch! ask this in slack?

@nina-py nina-py merged commit 35f3878 into main Sep 10, 2024
6 checks passed
@nina-py nina-py deleted the MC-1446 branch September 10, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants