Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix for sqla 1.4 update #48

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Hot Fix for sqla 1.4 update #48

merged 8 commits into from
Dec 21, 2023

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Dec 8, 2023

  • Delete CustomSelect,
  • Add qfilter decorator to replace queryclass

Check docstring for how to use qfilter

2023-12-19

Since CustomSelect is still used in GeoNature develop branch. Waiting for GeoNature hotfix/sqla1.4 merge to develop.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b5e306a) 83.45% compared to head (619b3ca) 82.65%.

Files Patch % Lines
src/utils_flask_sqla/models.py 89.65% 3 Missing ⚠️
src/utils_flask_sqla/serializers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
- Coverage    83.45%   82.65%   -0.81%     
===========================================
  Files            5        4       -1     
  Lines          266      271       +5     
===========================================
+ Hits           222      224       +2     
- Misses          44       47       +3     
Flag Coverage Δ
pytest 82.65% <86.66%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/utils_flask_sqla/tests/test_qfilter.py Outdated Show resolved Hide resolved
src/utils_flask_sqla/models.py Outdated Show resolved Hide resolved
jacquesfize and others added 2 commits December 19, 2023 10:38
Co-authored-by: Élie Bouttier <[email protected]>
@bouttier bouttier merged commit 619b3ca into develop Dec 21, 2023
5 of 6 checks passed
@bouttier bouttier deleted the hotfix/sqla1.4 branch December 21, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants