Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to tiles #49

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add links to tiles #49

merged 1 commit into from
Oct 20, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Sep 19, 2023

Closes #47

Allow to configure links in tiles:

Screenshot 2023-09-19 at 16 23 44

So the titles become links:

Screen.Recording.2023-09-19.at.16.22.52.mov

@fblupi fblupi added the enhancement New feature or request label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (836b8ea) 87.12% compared to head (16f714d) 87.24%.

❗ Current head 16f714d differs from pull request most recent head 7b61b5a. Consider uploading reports for the commit 7b61b5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   87.12%   87.24%   +0.11%     
==========================================
  Files          33       33              
  Lines         536      541       +5     
==========================================
+ Hits          467      472       +5     
  Misses         69       69              
Files Changed Coverage Δ
...m/alternative_landing/content_blocks/tiles_cell.rb 100.00% <100.00%> (ø)
...ve_landing/content_blocks/content_blocks_shared.rb 90.24% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fblupi fblupi marked this pull request as ready for review September 26, 2023 09:48
@fblupi fblupi marked this pull request as draft September 26, 2023 09:49
@rxnetwalker rxnetwalker requested a review from sbrocos October 19, 2023 14:21
@fblupi fblupi marked this pull request as ready for review October 20, 2023 10:48
@fblupi fblupi merged commit 92db8dd into main Oct 20, 2023
@fblupi fblupi deleted the feat/47 branch October 20, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiles: Links
3 participants